feat: specific generation of roles and clusterroles #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d changed deployament image in 'distroless'
… detection and error management when helm template is found in kind or apiVersion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
The core-provider can create a dedicated Role and ClusterRole when a composition-dynamic-controller is deployed.
An enhancement would be to inspect any GVK resource in the composition helm chart, check if that GVK is cluster or namespace scoped, and populate the Role and ClusterRole accordingly.
Solution Implemented
A specific generation of Roles and ClusterRoles has been implemented. Resources within the chart are placed either in a Role or a ClusterRole based on whether they are namespace-scoped or not.
Additional Notes