Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves Alpine select test #1257

Closed
wants to merge 1 commit into from
Closed

Improves Alpine select test #1257

wants to merge 1 commit into from

Conversation

ekwoka
Copy link

@ekwoka ekwoka commented May 2, 2023

This modifies the test implementation to improve efficiency.

This cuts down the select test by 89%

@ekwoka ekwoka changed the title Improves Alpine select Improves Alpine select test May 2, 2023
@krausest
Copy link
Owner

krausest commented May 9, 2023

Thanks and yes, but then I'd have to add #800 for this implementation. I suggest not to apply that optimization.

@krausest
Copy link
Owner

I'm closing this PR since I haven't got an answer and I'd like to avoid adding note 800.

@krausest krausest closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekwoka @krausest