Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plaited 3.0.0 #1258

Merged
merged 2 commits into from
May 9, 2023
Merged

plaited 3.0.0 #1258

merged 2 commits into from
May 9, 2023

Conversation

EdwardIrby
Copy link
Contributor

Adds plaited library to benchmarks

@EdwardIrby EdwardIrby changed the title plaited library plaited 3.0.0 May 9, 2023
@krausest krausest merged commit 2151ec8 into krausest:master May 9, 2023
@krausest
Copy link
Owner

krausest commented May 9, 2023

Thanks - not a bad first run!
I think we have to add note #800 (selected is a property of the row) and #772 (setting danger class directly). Do you agree?

Bildschirmfoto 2023-05-09 um 10 50 13 PM

@EdwardIrby
Copy link
Contributor Author

EdwardIrby commented May 10, 2023

Thanks - not a bad first run! I think we have to add note #800 (selected is a property of the row) and #772 (setting danger class directly). Do you agree?

Bildschirmfoto 2023-05-09 um 10 50 13 PM

Yep I agree this library takes an State Unmanagement first approach to the DOM. While there's a away to do it with my useStore utility to reflect state that's not really a pattern I'm recommending to users unless there doing something like d3 graphs.

Thanks for getting this in so quickly!!!

@EdwardIrby EdwardIrby deleted the plaited-1.0.3-rc branch November 21, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants