Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uhtml to v4 #1497

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Update uhtml to v4 #1497

merged 1 commit into from
Nov 12, 2023

Conversation

WebReflection
Copy link
Contributor

uhtml v4 is out so I'd like to have it tested and validated with all its improvements in here too, thank you!

Changes

  • update uhtml to its latest
  • update all dependencies to avoid deprecation warnings while bundling
  • changed minimal amount of code to validate results against previous version, without changing any other logic behind the test

@krausest krausest merged commit e57fe69 into krausest:master Nov 12, 2023
@krausest
Copy link
Owner

Thanks - here's how it looks like:
Screenshot 2023-11-12 at 7 22 44 PM

@WebReflection
Copy link
Contributor Author

It looks like either keyed or non keyed still uses v3 🤦🤦🤦😭

I’ll double check and follow up eventually, thank you

@WebReflection
Copy link
Contributor Author

OK, v4 is present in both keyed and non keyed … was build-prod missing or there’s something else I should look at? One screenshot refers to v3 and now I’m thinking that maybe that was the previous reference instead? Thanks for hints or clarification!

@krausest
Copy link
Owner

Sorry, that was me. I didn't publish the result table until a few moments ago!

@krausest
Copy link
Owner

krausest commented Nov 12, 2023

Ok, maybe I need more explanations 😄. For keyed implementations I use to publish a screenshot of the results for the current PRs (left side) and the last results for the same frameworks (right side) such that one can compare the new and the old versions. So the screenshot above is intended - and I hope it makes sense now.

To express my disgrace with non-keyed frameworks I only update the result table for non-keyed implementations and don't post a comparison. This time some interruption made me to forget updating the results table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants