Simplify lit-html benchmark code (without direct DOM manipulation) #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add semicolons, replace var with let, change some whitespace.
Previously a new row object was created on every select or update, in order to force a render given that the guard directive was used. However, it's simpler in this case to just not use the guard directive.
Removes some unnecessary attributes and uses closest() to find the action and row id.
|
Thanks a lot - results have been updated. Here's a screenshot: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as PR #521, but without the controversial change involving directly setting a class on the table row.
A few simplifications to the lit-html benchmark implementations:
selectandlabelproperties in-place and removeguarddirective, instead of creating new row objects every time.closest()to find the action and row id.Directly update row class on select instead of forcing an unnecessary render.cc @justinfagnani @rictic @CaptainCodeman