Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed MobX benchmark after upgrading by swapping minifier and enabling batching #752

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Fixed MobX benchmark after upgrading by swapping minifier and enabling batching #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions frameworks/keyed/react-mobX/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,14 @@
"babel-preset-react": "6.24.1",
"babel-preset-stage-0": "6.24.1",
"jsx-loader": "0.13.2",
"terser-webpack-plugin": "^3.0.6",
"webpack": "4.16.3",
"webpack-cli": "^3.1.0"
},
"dependencies": {
"mobx": "5.0.3",
"mobx-react": "5.2.3",
"react": "16.4.1",
"react-dom": "16.4.1"
"mobx": "5.15.4",
"mobx-react": "6.2.2",
"react": "16.13.1",
"react-dom": "16.13.1"
}
}
3 changes: 2 additions & 1 deletion frameworks/keyed/react-mobX/src/Main.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

var React = require('react');
var ReactDOM = require('react-dom');
require('mobx-react/batchingForReactDom');
const {Row} = require('./Row');
var {observer} = require("mobx-react");
var {observable, computed} = require ("mobx");
Expand Down Expand Up @@ -91,4 +92,4 @@ export class Main extends React.Component{

let store = new Store();

ReactDOM.render(<Main store={store}/>, document.getElementById('main'));
ReactDOM.render(<Main store={store}/>, document.getElementById('main'));
91 changes: 46 additions & 45 deletions frameworks/keyed/react-mobX/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,49 +1,50 @@
'use strict';
require("babel-plugin-syntax-jsx")
var path = require('path')
var webpack = require('webpack')
"use strict";
require("babel-plugin-syntax-jsx");
var path = require("path");
var webpack = require("webpack");
var TerserPlugin = require("terser-webpack-plugin");
var cache = {};
var loaders = [
{
test: /\.jsx$/,
loader: 'babel-loader'
},
{
test: /\.es6\.js$/,
loader: 'babel-loader'
},
{
test: /\.css$/,
loader: 'style-loader!css-loader'
}
];
var extensions = [
'.js', '.jsx', '.es6.js'
{
test: /\.jsx$/,
loader: "babel-loader",
},
{
test: /\.es6\.js$/,
loader: "babel-loader",
},
{
test: /\.css$/,
loader: "style-loader!css-loader",
},
];
var extensions = [".js", ".jsx", ".es6.js"];

module.exports = [{
cache: cache,
module: {
rules: loaders
},
entry: {
main: './src/Main.jsx',
},
output: {
path: path.resolve(__dirname, "dist"),
filename: '[name].js'
},
resolve: {
extensions: extensions,
modules: [
__dirname,
path.resolve(__dirname, "src"),
"node_modules"
]
},
plugins: [
new webpack.DefinePlugin({
'process.env.NODE_ENV': '"production"'
})
]
}];
module.exports = [
{
cache: cache,
module: {
rules: loaders,
},
entry: {
main: "./src/Main.jsx",
},
output: {
path: path.resolve(__dirname, "dist"),
filename: "[name].js",
},
resolve: {
extensions: extensions,
modules: [__dirname, path.resolve(__dirname, "src"), "node_modules"],
},
optimization: {
minimize: true,
minimizer: [new TerserPlugin()],
},
plugins: [
new webpack.DefinePlugin({
"process.env.NODE_ENV": '"production"',
}),
],
},
];