Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates #3

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Updates #3

merged 2 commits into from
Oct 11, 2024

Conversation

coltenkrauter
Copy link
Contributor

Description

Add README manager (needs a bit more work) and ensure that published packages get compiled to JavaScript first.

Type of Change

  • New feature
  • Bug fix
  • Chore
  • Configuration
  • Documentation
  • Refactoring
  • Hotfix
  • Security
  • GitFlow

Testing

  • Executed locally
  • Unit tests
  • Integration tests
  • Load tests
  • PR Status checks
  • Workflow execution (against non-default branch)
  • Other (explain)
  • Not worth it (explain)
  • Not applicable

Checklist

[Not required to be completed, just check off what you've done.]

  • Commits are reasonably sized and the commit message describes the changes well.
  • I have made corresponding changes to the documentation.
  • I have added unit tests for changes to business logic.
  • I have emitted metrics so our team can monitor the health of this system related to these changes.
  • I have added logs to ensure debugging is straight-forward when issues arise.
  • I have considered failure modes (e.g. major dependency becomes unavailable, bad data passed in).
  • I have added a comment to this PR to discuss any concerns/risks of these changes. This might include effects on performance, new dependencies, changes in behavior, or difficult things to test.
  • I have considered whether some of these changes should go into a shared package to increase code reusability.

@coltenkrauter coltenkrauter self-assigned this Oct 11, 2024
@coltenkrauter coltenkrauter force-pushed the updates branch 14 times, most recently from 2ab3682 to 1a7c260 Compare October 11, 2024 02:50
@coltenkrauter coltenkrauter merged commit 8a9640f into main Oct 11, 2024
2 checks passed
@coltenkrauter coltenkrauter deleted the updates branch October 20, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant