Make ProjectFactory overridable (#60)

kreait · May 28, 2024 · 3c683bf · 3c683bf
1 parent 5604be6
commit 3c683bf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/DependencyInjection/FirebaseExtension.php b/src/DependencyInjection/FirebaseExtension.php
@@ -65,8 +65,7 @@ private function registerService(string $name, string $postfix, array $config, s
         $projectServiceId = \sprintf('%s.%s.%s', $this->getAlias(), $name, $postfix);
         $isPublic = $config['public'];
 
-        $factory = new Definition(ProjectFactory::class);
-        $factory->setPublic(false);
+        $factory = $container->getDefinition(ProjectFactory::class);
 
         if ($config['verifier_cache'] ?? null) {
             $factory->addMethodCall('setVerifierCache', [new Reference($config['verifier_cache'])]);

diff --git a/src/Resources/config/firebase.xml b/src/Resources/config/firebase.xml
@@ -11,7 +11,7 @@
     <services>
         <service id="Kreait\Firebase\Factory" class="%kreait.firebase.factory%" />
 
-        <service id="Kreait\Firebase\Symfony\Bundle\DependencyInjection\Factory\ProjectFactory" class="%kreait.firebase.bundle.project_factory%">
+        <service id="Kreait\Firebase\Symfony\Bundle\DependencyInjection\Factory\ProjectFactory" class="%kreait.firebase.bundle.project_factory%" public="false">
             <argument type="service" id="Kreait\Firebase\Factory" />
         </service>
     </services>