Add support for Session Cookies #244
Conversation
|
Please is there any doc on how to use this yet? |
jeromegamez
force-pushed
the
feature/session-cookies
branch
from
9a424d0 to
54195c8
Compare
| if ($this->idTokenVerifier instanceof NewIdTokenVerifier) { | ||
| try { | ||
| $this->idTokenVerifier->verify($idToken); | ||
| } catch (Exception\InvalidToken $e) { |
There was a problem hiding this comment.
this catch InvalidToken hidden away exception message from inside verifier
for example, expired idToken will be thrown by verifyExpiry with message 'The token is expired since xxx'
with this too broad catch, will result in new InvalidToken without message from line 371
| @@ -58,7 +57,7 @@ public function getResponse() | |||
|
|
|||
| private static function getTargetClassFromStatusCode($code): string | |||
| { | |||
| if (\in_array($code, [StatusCode::STATUS_UNAUTHORIZED, StatusCode::STATUS_FORBIDDEN], true)) { | |||
| if (\in_array($code, [401, 403], true)) { | |||
There was a problem hiding this comment.
What is the reason to remove the usage of the constants?
There was a problem hiding this comment.
It's been quite some time, but I probably wanted to remove the transient dependency on the fig/http-message-util package (which is available through the inclusion of kreait/firebase-tokens). Removing that package would break this class.
I'm currently planning on a rework of both packages, so the issue might or might not apply in the future any more.
|
Postponed to after 5.0 |
Addresses #202
Todo