Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Make load tracking configurable #25

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

ArneZsng
Copy link
Contributor

@ArneZsng ArneZsng commented Apr 4, 2020

Adds the option "trackLoad" to make it configurable in the plugin settings if the load tracking event should be fired.

The option defaults to true to not make this a breaking change.

Copy link
Owner

@kremalicious kremalicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense!

Honestly, not so sure about that js loading duration tracking anymore so in a next major release probably turn around the logic and make it opt-in. But for now excellent idea just making it non-breaking

@kremalicious kremalicious merged commit d64e7ff into kremalicious:master Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants