Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent editor errors mvp #165

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Agent editor errors mvp #165

merged 2 commits into from
Aug 16, 2023

Conversation

kreneskyp
Copy link
Owner

Description

First pass at adding better form errors to Agent editor view:

  • error popup now lists the form errors.
  • added indicators to required fields.

image

Changes

  • agent form error popup now lists the form errors.
  • added indicators to required fields on agent form.

How Tested

[Explain how you tested this pull request. Include any relevant steps or scripts.]

TODOs

  • a followup PR should use chakra's error display properties for the input fields and display the error next to the input.

@kreneskyp kreneskyp merged commit dfdd6c9 into master Aug 16, 2023
@kreneskyp kreneskyp deleted the agent_editor_errors_mvp branch August 16, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kreneskyp