Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty reponse on provider registry json #145

Merged
merged 6 commits into from
Jun 29, 2023
Merged

Conversation

mavogel
Copy link
Contributor

@mavogel mavogel commented Jun 27, 2023

What does this do / why do we need it?

Fixes #137

How this PR fixes the problem?

By adding the flag --custom-provider-repository-url which avoid querying the terraform registry

What should your reviewer look out for in this PR?

if the flag make sense or we'd use a fallback and prepend https://github.com/

Check lists

  • Test passed
  • Coding style (indentation, etc)

Which issue(s) does this PR fix?

#137

Signed-off-by: Manuel Vogel <mavogel@posteo.de>
Signed-off-by: Manuel Vogel <mavogel@posteo.de>
@coveralls
Copy link

coveralls commented Jun 27, 2023

Pull Request Test Coverage Report for Build 5409359974

  • 17 of 22 (77.27%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 65.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/app/install.go 17 19 89.47%
internal/app/app.go 0 3 0.0%
Totals Coverage Status
Change from base Build 5345102601: 0.6%
Covered Lines: 338
Relevant Lines: 520

💛 - Coveralls

Signed-off-by: Manuel Vogel <mavogel@posteo.de>
Signed-off-by: Manuel Vogel <mavogel@posteo.de>
Signed-off-by: Manuel Vogel <mavogel@posteo.de>
@mavogel mavogel marked this pull request as ready for review June 27, 2023 14:38
@mavogel mavogel merged commit 3eb420a into main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for fetching provider sources from archived repositories?
2 participants