Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

png broken after git commit #1072

Closed
giftman opened this issue Jan 8, 2017 · 4 comments
Closed

png broken after git commit #1072

giftman opened this issue Jan 8, 2017 · 4 comments

Comments

@giftman
Copy link

giftman commented Jan 8, 2017 •
edited
Loading

try to add "*.png binary" in .gitattributes,but it's not working. I'm not sure what's going wrong.Please help.

my env:
macos sierra 10.12.2
@frenzzy
Copy link
Member

frenzzy commented Jan 8, 2017

Please try to remove this line from package.json

@giftman
Copy link
Author

giftman commented Jan 9, 2017

@frenzzy remove that line fix the problem,thank you!

@giftman
Copy link
Author

giftman commented Jan 9, 2017 •
edited
Loading

screen shot 2017-01-09 at 11 16 17 am

I found it can work with the .editorconfig like this..

@rochadt
Copy link

rochadt commented Jan 10, 2017

@frenzzy can we get an updated pr for this on frenzzy/pre-commit? This issue appears to affect all newly added images.

JasonPierce pushed a commit to 2Toad/react-starter-kit that referenced this issue Apr 18, 2017
@koistya
Fix kriasoft#1072: Images broken after Git commit
1a05abd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frenzzy @rochadt @giftman