Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): add core-js to unmockedModulePathPatterns #511

Merged
merged 1 commit into from
Mar 17, 2016

Conversation

JeffreyATW
Copy link

This seems to solve the issue seen in #491. I don't see any reason why core-js should need to be mocked.

@JeffreyATW JeffreyATW changed the title Adding core-js to unmockedModulePathPatterns fix(test): add core-js to unmockedModulePathPatterns Mar 17, 2016
koistya added a commit that referenced this pull request Mar 17, 2016
fix(test): add core-js to unmockedModulePathPatterns
@koistya koistya merged commit 154c418 into kriasoft:master Mar 17, 2016
@koistya
Copy link
Member

koistya commented Mar 17, 2016

Cool, thanks!

@everdimension
Copy link

@JeffreyATW
Were you able to run npm test successfully after this change? It just throws another error when I try.

@JeffreyATW
Copy link
Author

@everdimension Yes, I got my stuff to pass, but I also removed all Links from my Footer, so you might have to unmock "history" as well, which is what the Location core helper uses and seems to fail on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants