Start Pair contract + Math + UQ112x112 libs #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kris524
changed the title
|
I have added the basic libraries. Next I will continue with the Pair contract |
brson
reviewed
Jun 21, 2022
brson
reviewed
Jun 21, 2022
brson
reviewed
Jun 21, 2022
brson
reviewed
Jun 21, 2022
| } | ||
|
|
||
| pub mod UQ112x112 { | ||
| const Q112: U224 = 2**112; |
There was a problem hiding this comment.
I am guessing this doesn't build - I don't think ** is a rust operator. You can get the value of 2*112 with 2_u128.pow(112). And pow is a constant function so you can assign that to a const Q112: u128, but I don't see an obvious way to put that value into a U224 constant. You might have to call U224::from whenever you want to use the constant.
There was a problem hiding this comment.
Not sure what to do with that file still. Maybe I will leave it for now and get back to it later
brson
reviewed
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.