Fix require-sql to use . instead of / in internal ns name #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the require-sql macro doesn't currently work, as it places the functions it defines into an invalid namespace.
Using the macro like:
Results in:
since the internal namespace created to hold the functions has an invalid char
/
within it (yesquire/queries.sql
).The tests in
yesql.core-test
also exhibit this problem, but since the functions aren't invoked the problem isn't obvious.This change fixes the internal namespace in which the query functions are placed by using
.
rather than/
chars in the ns name. I've also added an actual invocation of the declared query fns into the test to verify that the functions can be called.