enable registering multiple plugins with same name #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megies
added a commit
to krischer/jane
that referenced
this pull request
May 9, 2016
note that this needs krischer/django-plugins#11 to work
by enumerating index field and adding it to the unique key
megies
force-pushed
the
fix_multiple_plugins_same_name
branch
from
0fdd130
to
31ae955
Compare
|
Rebased and force-pushed (previous PR tip was 0fdd130). Also adding this change to initial migrations. |
megies
added a commit
to megies/jane
that referenced
this pull request
Sep 26, 2017
note that this needs krischer/django-plugins#11 to work
so existing installations can be updated properly
megies
force-pushed
the
fix_multiple_plugins_same_name
branch
from
b6b7d0c
to
19f631f
Compare
was getting error messages about duplicate keys, looks like the id counter is automatically incremented as a uniq field but that index field might not be as a plain integer field (not handled by postgres at all?)
megies
force-pushed
the
fix_multiple_plugins_same_name
branch
from
cdcdf46
to
f38b6c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By enumerating index field and adding it to the unique key.
This fixes a problem I have in a project depending on
django-plugins. Not sure if this is the right way to fix this or if the index field is used otherwise in different spots. I didn't see it in use in any case.. @krischer?