add setting to display terminal name on hover (tooltip)

krish-r · May 26, 2024 · 3c00cbc · 3c00cbc
1 parent 50d8b7c
commit 3c00cbc
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -42,3 +42,10 @@
 ### Added
 
 - Added setting to display terminal name on hover (tooltip).
+
+## [0.0.7] - 2024-05-27
+
+### Added
+
+- Added setting to display terminal name on hover (tooltip).
+
diff --git a/README.md b/README.md
@@ -74,6 +74,6 @@ If you come across any other issue, or if you could improve this extension pleas
 -   Added setting for priority.
 -   Added notification to reload on configuration changes.
 
-### 0.0.6
+### 0.0.6, 0.0.7
 
  - Added setting to display terminal name on hover (tooltip).
diff --git a/package.json b/package.json
@@ -3,7 +3,7 @@
     "displayName": "Toggle Terminal",
     "publisher": "krish-r",
     "description": "This extension adds a terminal toggle icon (shortcut) in the status bar.",
-    "version": "0.0.6",
+    "version": "0.0.7",
     "engines": {
         "vscode": "^1.74.0"
     },

diff --git a/src/extension.ts b/src/extension.ts
@@ -4,6 +4,7 @@ import * as vscode from "vscode";
 let statusBarItem: vscode.StatusBarItem;
 let disposable: vscode.Disposable;
 let isTerminalVisible = false;
+let listNames = false;
 
 export function activate({ subscriptions }: vscode.ExtensionContext) {
     const extensionName = "vscode-toggle-terminal";
@@ -26,33 +27,33 @@ export function activate({ subscriptions }: vscode.ExtensionContext) {
             ? vscode.StatusBarAlignment.Right
             : vscode.StatusBarAlignment.Left;
     const priority = conf.get<number>("priority");
-    const listNames = conf.get<boolean>("listNames") || false;
+    listNames = conf.get<boolean>("listNames") || false;
 
     statusBarItem = vscode.window.createStatusBarItem(alignment, priority);
     statusBarItem.command = commandId;
     statusBarItem.name = "Toggle Terminal";
     statusBarItem.text = `$(terminal) ${vscode.window.terminals.length}`;
-    statusBarItem.tooltip = listTerminalNames(listNames);
+    statusBarItem.tooltip = listTerminalNames();
     statusBarItem.show();
 
     subscriptions.push(statusBarItem);
 
     vscode.window.onDidChangeTerminalState(() => {
         statusBarItem.text = `$(terminal) ${vscode.window.terminals.length}`;
-        statusBarItem.tooltip = listTerminalNames(listNames);
+        statusBarItem.tooltip = listTerminalNames();
     });
     vscode.window.onDidChangeActiveTerminal(() => {
         statusBarItem.text = `$(terminal) ${vscode.window.terminals.length}`;
-        statusBarItem.tooltip = listTerminalNames(listNames);
+        statusBarItem.tooltip = listTerminalNames();
     });
     vscode.window.onDidOpenTerminal(async () => {
         statusBarItem.text = `$(terminal) ${vscode.window.terminals.length}`;
         await sleep(500);
-        statusBarItem.tooltip = listTerminalNames(listNames);
+        statusBarItem.tooltip = listTerminalNames();
     });
     vscode.window.onDidCloseTerminal(() => {
         statusBarItem.text = `$(terminal) ${vscode.window.terminals.length}`;
-        statusBarItem.tooltip = listTerminalNames(listNames);
+        statusBarItem.tooltip = listTerminalNames();
     });
 
     vscode.workspace.onDidChangeConfiguration(
@@ -83,6 +84,7 @@ function toggleTerminal() {
         }
         isTerminalVisible = true;
     }
+    statusBarItem.tooltip = listTerminalNames();
 }
 
 function reloadWindow() {
@@ -100,9 +102,9 @@ function reloadWindow() {
         });
 }
 
-function listTerminalNames(enabled: boolean) {
+function listTerminalNames() {
     let defaultValue = "Toggle Terminal";
-    if (!enabled) {
+    if (!listNames) {
         return defaultValue;
     }