-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create greetings.yaml #231
Conversation
Added for krishnaacharyaa#228
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi Mate, you are missing lots of places, please slow down and give attention to detail
Chat gpt /bard gives me this ... You have greeting template going not sure how this is greeting, it is mostly a warning message, I don't want to greet anyone tbh. @Mayur-666 please take care of this use case, it will be challenging but high need #230, test it in your other project and then raise the PR. Because this is the need, I'll revise the acceptance criteria soon for this issue.... |
@krishnaacharyaa I have this one in mind name: 'Greetings' on: jobs: |
@krishnaacharyaa It will be something like this / or we can do some changes in message |
LGTM, we'll change the message, not getting if it is the issue wala or the PR wala... ig you wantedly just tried both the things In #230 there are many other factors, written neatly in the acceptance criteria, can you kindly look into that. |
Yes sure @krishnaacharyaa |
ig you have picked it from here Sanchitbajaj02/palettegram#306 He has used some bots in the PR as well, can you look into that? And see if even we can leverage that kinda thing. |
well i have taken it from swapnil, he's my friend and we made that at time of social summer of code. |
@Mayur-666 Then I guess this guy has taken from swapalin aswell 😂😂 |
Added for #228