Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill out results page #28

Merged
merged 28 commits into from
Apr 24, 2024
Merged

Fill out results page #28

merged 28 commits into from
Apr 24, 2024

Conversation

vincerubinetti
Copy link
Collaborator

@vincerubinetti vincerubinetti commented Apr 18, 2024

Closes #29

Please excuse the poor commit history and large scope on this one. To aid in review, I'll mark important places in the code to take a look at.

  • update msw api mocks to match the new post endpoints
  • improve type definitions for api requests and responses, with collocated transformation functions
  • for zag components, move props to declarative "context" arguments (that update when changed) instead of just being initialized to those values. see here
  • add nicely formatted exponential component
  • make dedicated "mark" component with icon and text
  • refactor and fixup select component a bit
  • simplify slider component marks
  • rework table component. add tooltip option for header cells. add expand control. move all controls to bottom for cleanness.
  • remove use-query-params package. just use react-router built-in useSearchParams (for now)
  • add basic [load] analysis page. ability to download/upload inputs/results, or take inputs sent to it from new analysis page and run query for results. add tabs for each part of results. basic tables for most tabs, then one network tab.
  • network tab. uses d3-force for physics simulation, d3-zoom for view zoom/pan, d3-drag for node dragging. tries to use react for declarative rendering as much as possible.
  • add download svg util func
  • add/update custom useQuery hook that replaces tanstack react table (simpler, more control)
  • add some math util funcs
  • tweak format number util func to print small numbers more nicely
  • update cloud functions: add brotli compression, print full stack trace on error, fix status codes

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for gene-plexus ready!

Name Link
🔨 Latest commit 010f968
🔍 Latest deploy log https://app.netlify.com/sites/gene-plexus/deploys/6627e0c114b57a00084d0f14
😎 Deploy Preview https://deploy-preview-28--gene-plexus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@falquaddoomi falquaddoomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat; I admit the code changes are a lot to review, but I ran it locally and it seems like things are working.

Also, nice to see you made the backend compression and error reporting changes, too.

@vincerubinetti vincerubinetti merged commit 8c2fefc into main Apr 24, 2024
3 checks passed
@vincerubinetti vincerubinetti deleted the results branch April 24, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable compression in functions
3 participants