Review comments, bug fixes, tweaks #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vincerubinetti
commented
Jul 26, 2024
•
vincerubinetti
commented
- migrate eslint to v9, remove lint script
- tweak recommended vscode extensions
- upgrade all packages
- split analysis page into analysis and load-analysis pages
- rename "input" to "inputs" where appropriate, for consistency
- add request-level cache, and tweak request util func
- fix header and section component tags
- debounce header minify to improve "bug" when slowly scrolling down from top
- remove star imports for consistency, clarity, and more confidence in tree shaking
- fix select component dropdown being under footer (z-index issue)
- upgrade to headless ui v2 (builds in anchor position, removes need for headless-float package)
- tweak slider component marker visibility
- change table component default "per page" selection
- use toLocaleString on a few numbers i missed
- improve a few type castings in table component
- close table of contents when covering important elements,
- preserve history state in table of contents links, so clicking on one doesn't unset the "current analysis" inputs+results set in the state
- fix upload button tooltip and accept attr
- simplify analysis page state vars. redirect to load page if empty.
- rearrange buttons on analysis page
- remove useless vestigial debounce in input genes on new analysis page (user now has to click button explicitly)
- have fallback node color in network viz
- change default network visualization node label from entrez id to symbol
- refactor legend rendering in network viz. make more automatic and consistent
- refactor scroll to util func to fix chrome bug where simultaneous programmatic scrolls cancel each other
- fix tooltip shrink wrap bug (e.g. on 3-fold hover)
- remove useless cache in usequery func and move to request func (usequery cache would get cleared any time page unmounted/remounted, which is also only time query would re-run and cache could be used anyway)
✅ Deploy Preview for gene-plexus ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vincerubinetti
requested review from
falquaddoomi
and removed request for
falquaddoomi
vincerubinetti
changed the title
|
These are great. The issues I raised before in the google doc that were marked "Will fix in PR #37" have been addressed. The other issues remain. In addition, I've added a few more to the top of the same google doc. |
vincerubinetti
added a commit
to JRaviLab/molevolvr2.0
that referenced
this pull request
Aug 28, 2024
Note that the diff here is a pain because I had to do a bulk `chmod` due to a playwright setup command messing with a bunch of file permissions, and couldn't find a way to reset the permissions to their defaults (pre-playwright-command) without going through one file at a time. - pull in various improvements from krishnanlab/geneplexus-app-v2#37 and krishnanlab/geneplexus-app-v2#38 - update test workflow: fix trigger, update action versions, update debugging steps, add e2e playwright testing with caching - setup playwright for e2e and accessibility testing - add status indicator to analysis card component - enable msw network request mocking - don't allow empty "lookup analysis" - install and setup axe-core (library that powers chrome dev tools' lighthouse accessibility check) - check all major pages of app (so far) for accessibility issues - add basic e2e test for demonstration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.