Revert "allow to pass a getFn for a specific key"

This reverts commit 20668ec.
krisk · May 3, 2022 · 9d7fc44 · 9d7fc44
1 parent 604781a
commit 9d7fc44
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 30 deletions.
diff --git a/src/tools/FuseIndex.js b/src/tools/FuseIndex.js
@@ -92,7 +92,7 @@ export default class FuseIndex {
     // Iterate over every key (i.e, path), and fetch the value at that key
     this.keys.forEach((key, keyIndex) => {
       // console.log(key)
-      let value = key.getFn ? key.getFn(doc) : this.getFn(doc, key.path)
+      let value = this.getFn(doc, key.path)
 
       if (!isDefined(value)) {
         return

diff --git a/src/tools/KeyStore.js b/src/tools/KeyStore.js
@@ -67,7 +67,7 @@ export function createKey(key) {
     id = createKeyId(name)
   }
 
-  return { path, id, weight, src, getFn: key.getFn }
+  return { path, id, weight, src }
 }
 
 export function createKeyPath(key) {

diff --git a/test/indexing.test.js b/test/indexing.test.js
@@ -29,18 +29,6 @@ describe('Searching', () => {
     expect(myIndex.keys).toBeDefined()
   })
 
-  test('createIndex: ensure keys can be created with getFn', () => {
-    let myIndex = Fuse.createIndex(
-      [
-        { name: 'title', getFn: (book) => book.title },
-        { name: 'author.firstName', getFn: (book) => book.author.firstName }
-      ],
-      Books
-    )
-    expect(myIndex.records).toBeDefined()
-    expect(myIndex.keys).toBeDefined()
-  })
-
   test('parseIndex: ensure index can be exported and Fuse can be initialized', () => {
     const myIndex = Fuse.createIndex(options.keys, Books)
     expect(myIndex.size()).toBe(Books.length)
@@ -58,22 +46,6 @@ describe('Searching', () => {
     expect(idx(result)).toMatchObject([0])
   })
 
-  test('parseIndex: search with getFn', () => {
-    const fuse = new Fuse(Books, {
-      useExtendedSearch: true,
-      includeMatches: true,
-      includeScore: true,
-      threshold: 0.3,
-      keys: [
-        { name: 'title', getFn: (book) => book.title },
-        { name: 'authorName', getFn: (book) => book.author.firstName }
-      ]
-    })
-    const result = fuse.search({ title: 'old man' })
-    expect(result.length).toBe(1)
-    expect(idx(result)).toMatchObject([0])
-  })
-
   test('Fuse can be instantiated with an index', () => {
     let myIndex = Fuse.createIndex(options.keys, Books)
     const fuse = new Fuse(Books, options, myIndex)