Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable esm transpilation - fixes IE11 compatibility. #423

Closed
wants to merge 1 commit into from

Conversation

avilv
Copy link

@avilv avilv commented May 24, 2020

No description provided.

@avilv avilv mentioned this pull request Jun 2, 2020
@klarstrup
Copy link

4 releases since this PR went up, any feedback @krisk?

@avengerx
Copy link

Isn't this just a config setting and pull request sets this IE11 compatibiliuty "on by default"?

Just wondering if this should be a documentation issue or considered a bug.

@radhikagupta5
Copy link

radhikagupta5 commented Jun 16, 2020

Any update on when this would be merged and released? @krisk

Would like to use latest version of Fuse but unable to use since we need support IE11 as-well.

@krisk
Copy link
Owner

krisk commented Jun 28, 2020

Could you not simply use fuse.common.js? See here

@avilv
Copy link
Author

avilv commented Jun 29, 2020

Could you not simply use fuse.common.js? See here

this would work for old webpack / browserify, but not for anything modern that uses the ESM output (i.e, webpack2, angular cli, react etc. )

@Qrymy
Copy link

Qrymy commented Oct 29, 2020

@krisk
Hi, I'm using fuse.js, and great library, thanks!
And I'm facing ie11 build problem. I know I should use fuse.common.js, however I'm using with Next.js x TypeScript.
So there is no type definitions in fuse.common.js, So I suggest you two ideas.

  1. Merge this pr
    This is most easiest way, but bundle size will be larger than now, and ie11 will be disappear soon (1 year or more...).

  2. Create esm for ie11
    This way is so clever, react-hook-form is doing. For example,

import Fuse from 'fuse.js' // this is support except ie11
import Fuse from 'fuse.js/dist/fuse.ie11' this is support also ie11

If you adopt this way, normal bundle size will be same, and if ie11 disappear, you should remove as soon as possible.

If you think this way is good, I will make pr.

Thanks.

@mcrawshaw
Copy link

@krisk will @Qrymy suggestion work?

@Reached
Copy link

Reached commented Dec 12, 2020

Could we get this merged in by any chance? :)

EDIT:
I just made my own fork, compiled with the changes from this PR, and can confirm that it solves compatibility issues in both IE11 and Edge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants