fix(typescript): fieldNormWeight should be optional, fixes #650
#648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `fieldNormWeight` config option has a default value of `1`, and can therefore be optional (like the other config options) https://github.com/krisk/Fuse/blob/a9e00804497a1bfd7a94040520417825c085c945/src/core/config.js#L58-L59
|
Created a duplicate pull request before finding this one. Agreed! |
|
This would fix #650 |
|
Haha I was also too hurried. I repeat here for the maintainers: FYI you may be interested in built-in |
BenJenkinson
added a commit
to BenJenkinson/Fuse
that referenced
this pull request
May 5, 2022
### Changes - **Make `FuseOptionKeyObject.weight` property optional (and add description taken from docs)** - **Add `FuseOptionKeyObject.getFn` property (and add description taken from docs)** - Add `FuseOptionKeyObjectGetFunction` type to match existing `FuseGetFunction` type - Make `FuseOptionKeyObject` a generic, to allow typing the `getFn` method argument - Make `FuseOptionKey` a generic, to allow making `FuseOptionKeyObject` a generic - Convert some existing inline comments `// foo` to jsdoc comments `/** foo */` so they will be included in intellisense ### Related issues - Fixes krisk#655 ### See also - PR krisk#648
BenJenkinson
changed the title
fieldNormWeight should be optionalfieldNormWeight should be optional
BenJenkinson
changed the title
fieldNormWeight should be optionalfieldNormWeight should be optional, fixes #650
|
Fixed in latest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fieldNormWeightconfig option has a default value of1, and can therefore be optional (like the other config options)Fuse/src/core/config.js
Lines 58 to 59 in a9e0080
Related issues
Was this a regression?
fieldNormWeightwas valid in <= 6.5.3 (though only because it was missing from the type definition), and is now unnecessarily required in 6.6.0