WIP Decouple observable mixins #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I begin rolling out packages in the
@collectionsorg, committing to these API’s has me reflecting on my certainty that they’re lasting and final. One thing I would like to change while we still have a chance is coupling to the observer implementations.Rather than mixin observables, I would like to apply a delegate pattern so users can bring their own dispatch implementation.
I’ve started with
dequeto illustrate. In this change I remove the ObservableRange and ObservableProperty mixins. ObservableProperty is completely unnecessary, since you can just that API directly on any object. ObservableRange I would like to replace withrangeChangeDispatcherandrangeWillChangeDispatcherdelegate objects.