(REBASE) Remove collections dependency and es6-set instead #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since [collections module][1] modifies native objects, it's only good to be used as a top dependency of an application and not modules that it's using. The problem is that this will conflict if native objects has been modified by another module, let's say something like [sugar][2] or just another version of collections. When you have two of these being used in your app, you might be in trouble, where some code depends on a behaviour of a method implemented by one module but actually the method had been silently overriden by another module having a different behaviour. [1]: http://collectionsjs.com [2]: http://sugarjs.com
This was referenced Jul 11, 2018
|
I think it’s very reasonable to land this in a minor or patch. The dependency on collections is not part of the interface contract. |
kriskowal
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via @alFReD-NSH rebase on v1
1.2 ?