use instanceof to determine whether an object is a Q promise inside function Q #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilicvane
changed the title
|
I am likely to merge this. |
|
hope you will. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering modules using nested Q may have different versions or plugins (yup, such as my q-retry), I think it would be safer to determine whether the Q-promise-alike object is the instance of current Q promise constructor. So that the promise chain would be more reliable especially when promises are widely used in different modules.
This would bring a little bit performance impact, but it should be considered minor (actually only one more coerce for two modules and a single chain).