Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unhandled rejection reason strings #817

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Improve unhandled rejection reason strings #817

wants to merge 6 commits into from

Commits on Jun 16, 2017

  1. If a rejection is an Error, tweak the unhandled rejection string to… 

    … always contain the error's type and message since some browsers (like Firefox) don't include the error type/message in `reason.stack`.
    @timmfin
    timmfin committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    2b85064 View commit details
    Browse the repository at this point in the history

  2. Add a Q.customizeRejectionString hook which can be used to customiz… 

    …e how the rejection is string-ified.
    @timmfin
    timmfin committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    163ab6d View commit details
    Browse the repository at this point in the history

  3. Fix test for improved Firefox behavior

    @timmfin
    timmfin committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    38847a7 View commit details
    Browse the repository at this point in the history

  4. Adds tests for the Q.customizeRejectionString hook

    @timmfin
    timmfin committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    9f3e382 View commit details
    Browse the repository at this point in the history

  5. Fix whitespace in the tests newly added (accidentally copied in some … 

    …tabs from elsewhere in the file).
    @timmfin
    timmfin committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    2c5bc05 View commit details
    Browse the repository at this point in the history

  6. Add some items to the changes doc.

    @timmfin
    timmfin committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    a9d8b28 View commit details
    Browse the repository at this point in the history