Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated urllib3 secure extra #2

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Remove deprecated urllib3 secure extra #2

merged 1 commit into from
Oct 3, 2023

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Sep 6, 2023

urllib3[secure] has been deprecated and will be removed in the future.
AFAICT the secure extra isn't used anywhere, so it's safe to remove it.

More details

@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 2, 2023

@krismolendyke Would you mind taking a look at this?

@krismolendyke krismolendyke merged commit 4d68807 into krismolendyke:master Oct 3, 2023
@cdce8p cdce8p deleted the remove-urllib3-secure branch October 3, 2023 13:17
@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 3, 2023

Thanks @krismolendyke, appreciate you making a new release so quickly!
It seems 1.5.0 wasn't uploaded to PyPI, could you check that?

https://pypi.org/project/tank-utility/

@krismolendyke
Copy link
Owner

Will do @cdce8p. Having some issues w/ what seems to be related to pypi/warehouse#10030. I haven't dug into it yet but a simple upload to PyPI is getting kicked back w/ a 400.

@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 4, 2023

Having some issues w/ what seems to be related to pypi/warehouse#10030. I haven't dug into it yet but a simple upload to PyPI is getting kicked back w/ a 400.

Strange. Just because of interest, I tried uploading the package to https://test.pypi.org. (With a slightly different name tank_utility_test.) That worked without issues. If it helps, these are the steps I used

python3.11 -m venv venv-311
source venv-311/bin/activate
pip install build twine wheel

python -m build
twine check dist/*
twine upload --repository testpypi dist/*

# Building with setuptools worked as well
pip install setuptools
python setup.py sdist bdist_wheel
twine check dist/*
twine upload --repository testpypi dist/*

@krismolendyke
Copy link
Owner

krismolendyke commented Oct 5, 2023 via email

@krismolendyke
Copy link
Owner

Got it, definitely rusty uploading to PyPI 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants