Fixed changes requested by @srenatus (squash before merge)

Fixes open-policy-agent#4140 Signed-off-by: Kristian Svalland <kristian.svalland@gmail.com>
kristiansvalland · Jan 10, 2022 · 1c7d15a · 1c7d15a
1 parent a21ddde
commit 1c7d15a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/wasm/src/encoding.c b/wasm/src/encoding.c
@@ -39,6 +39,7 @@
 #include <limits.h>
 
 #include "json.h"
+#include "malloc.h"
 #include "value.h"
 
 static const unsigned char base64_table[65] =
@@ -334,5 +335,6 @@ opa_value *opa_json_is_valid(opa_value *a)
 		return opa_boolean(false);
 	}
 
+	opa_free(r);
 	return opa_boolean(true);
 }
diff --git a/wasm/tests/test.c b/wasm/tests/test.c
@@ -1790,8 +1790,8 @@ void test_json(void)
 {
     test("json/marshal", opa_value_compare(opa_json_marshal(opa_string_terminated("string")), opa_string_terminated("\"string\"")) == 0);
     test("json/unmarshal", opa_value_compare(opa_json_unmarshal(opa_string_terminated("\"string\"")), opa_string_terminated("string")) == 0);
-    test("json/is_valid_true", opa_value_compare(opa_json_is_valid(opa_string_terminated("\"string\"")), opa_boolean(true)) == 0);
-    test("json/is_valid_false", opa_value_compare(opa_json_is_valid(opa_string_terminated("\"string")), opa_boolean(false)) == 0);
+    test("json/is_valid_true", opa_cast_boolean(opa_json_is_valid(opa_string_terminated("\"string\"")))->v);
+    test("json/is_valid_false", !opa_cast_boolean(opa_json_is_valid(opa_string_terminated("\"string")))->v);
 }
 
 WASM_EXPORT(test_object)