non manifold issue

[benoitpaillard]

Hey man, thanks for the tool, very useful these days ! haha

I'm getting a non-manifold issue in the slicer for 3D printing, any idea how to solve that ?

Cheers.

[kristov]

Hello! I noticed on a few parts if there are "subtractive" operations on the model my tool fails to capture these correctly. For example Technic blocks have a hole in the stud on the top and my code fails to handle that case so the stud comes out solid. I suspect your issue might be related to that. Would you be able to paste me the part filename you are trying to convert?

[benoitpaillard]

Hi, the simple plates like 3020 etc... Give non manifold, yet pretty much printable parts.

…

On Thu, Apr 30, 2020, 10:43 AM Chris Eade ***@***.***> wrote: Hello! I noticed on a few parts if there are "subtractive" operations on the model my tool fails to capture these correctly. For example Technic blocks have a hole in the stud on the top and my code fails to handle that case so the stud comes out solid. I suspect your issue might be related to that. Would you be able to paste me the part filename you are trying to convert? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTHGTJ52JZRQ3YBQ3TUWS3RPE24HANCNFSM4MR5L3BQ> .

[kristov]

Ok I will check it out and get back to you - thanks!

[kristov]

Commit c05cf2c looks like it may work for 3020.dat at least. However I am not confident that I BFC extension behavior working correctly, so meanwhile I am working on what I hope is the proper solution. Once I am happy with a proper solution I will test more parts to make sure it's a real fix.

[jmerc77]

found the issue with the flipping...
line 216 in parser.pm: change elsif to if
fixed it for me. however, holes may still be a problem and has nothing to do with the code but the way ldraw parts are created.

[jmerc77]

my first pull request ever!
flipped face fix

[kristov]

Merged! Thanks a lot for the contribution :-)