forked from hollie/misterhouse
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Map aldb to I2 if get_engine_version returns NAK
Handle new device where engine_version is blank Add failure_reason to Insteon::Message Add failure callback to get_engine_version message On message timeout call message failure callback prior to clear_active_message
- Loading branch information
Michael Stovenour
committed
Mar 21, 2013
1 parent
0cba9f3
commit 058f80e
Showing
3 changed files
with
74 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So moving the clear_active_message() down below the callback is what is causing hollie#175. The failure callback will eventually call scan_link_table on the next device. However, when the failed active message is not cleared first, we end up right back at this spot again when scan_link_table for the next device calls process_queue. This will continue until all devices have "failed."
Do you remember why you moved this to line 267 below?