Skip to content
This repository has been archived by the owner on Jul 10, 2022. It is now read-only.

Add option for custom gpg command #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/deb/s3/cli.rb
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,11 @@ class Deb::S3::CLI < Thor
:type => :string,
:desc => "Additional command line options to pass to GPG when signing."

class_option :gpg_cmd,
:default => "",
:type => :string,
:desc => "Arbitrary gpg command to run for signing."

class_option :encryption,
:default => false,
:type => :boolean,
Expand Down Expand Up @@ -597,6 +602,7 @@ def configure_s3_client
Deb::S3::Utils.bucket = options[:bucket]
Deb::S3::Utils.signing_key = options[:sign]
Deb::S3::Utils.gpg_options = options[:gpg_options]
Deb::S3::Utils.gpg_cmd = options[:gpg_cmd]
Deb::S3::Utils.prefix = options[:prefix]
Deb::S3::Utils.encryption = options[:encryption]

Expand Down
10 changes: 6 additions & 4 deletions lib/deb/s3/release.rb
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,11 @@ def write_to_s3

# sign the file, if necessary
if Deb::S3::Utils.signing_key
local_file = release_tmp.path+".asc"
key_param = Deb::S3::Utils.signing_key != "" ? "--default-key=#{Deb::S3::Utils.signing_key}" : ""
if system("gpg -a #{key_param} --digest-algo SHA256 #{Deb::S3::Utils.gpg_options} -s --clearsign #{release_tmp.path}")
local_file = release_tmp.path+".asc"
gpg_cmd = Deb::S3::Utils.gpg_cmd != "" ? Deb::S3::Utils.gpg_cmd : "gpg"

if system("#{gpg_cmd} -a #{key_param} --digest-algo SHA256 #{Deb::S3::Utils.gpg_options} -s --clearsign #{release_tmp.path}")
remote_file = "dists/#{@codename}/InRelease"
yield remote_file if block_given?
raise "Unable to locate InRelease file" unless File.exists?(local_file)
Expand All @@ -113,8 +115,8 @@ def write_to_s3
else
raise "Signing the InRelease file failed."
end
if system("gpg -a #{key_param} --digest-algo SHA256 #{Deb::S3::Utils.gpg_options} -b #{release_tmp.path}")
local_file = release_tmp.path+".asc"

if system("#{gpg_cmd} -a #{key_param} --digest-algo SHA256 #{Deb::S3::Utils.gpg_options} -b #{release_tmp.path}")
remote_file = self.filename+".gpg"
yield remote_file if block_given?
raise "Unable to locate Release signature file" unless File.exists?(local_file)
Expand Down
2 changes: 2 additions & 0 deletions lib/deb/s3/utils.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ def signing_key; @signing_key end
def signing_key= v; @signing_key = v end
def gpg_options; @gpg_options end
def gpg_options= v; @gpg_options = v end
def gpg_cmd; @gpg_cmd end
def gpg_cmd= v; @gpg_cmd = v end
def prefix; @prefix end
def prefix= v; @prefix = v end
def encryption; @encryption end
Expand Down