Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add security audit by ChainLight #200

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

0xHansLee
Copy link
Contributor

No description provided.

@0xHansLee 0xHansLee requested a review from a team September 18, 2023 08:16
@seolaoh
Copy link
Contributor

seolaoh commented Sep 18, 2023

How about add a line in README.md like below?
See [here](./audits) for security audit reports.

@0xHansLee
Copy link
Contributor Author

How about add a line in README.md like below?
See here for security audit reports.

I also thought about it, but I didn't. I thought we don't need to state here about audits because it is About Kroma.
It'd better to make a separate section for security audits. wdyt?

@seolaoh
Copy link
Contributor

seolaoh commented Sep 18, 2023

How about add a line in README.md like below?
See here for security audit reports.

I also thought about it, but I didn't. I thought we don't need to state here about audits because it is About Kroma. It'd better to make a separate section for security audits. wdyt?

Yes, I suggested it to add the instruction about audit report somewhere in this repository. It does not need to be in README.md.

@0xHansLee 0xHansLee force-pushed the docs/add-theori-audit branch from 28e7fe1 to cd5d450 Compare September 18, 2023 09:59
@0xHansLee 0xHansLee force-pushed the docs/add-theori-audit branch from cd5d450 to a28aa3f Compare September 18, 2023 10:08
Copy link
Contributor

@kangsorang kangsorang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@seolaoh seolaoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seolaoh seolaoh merged commit c5f11bc into dev Sep 19, 2023
@seolaoh seolaoh deleted the docs/add-theori-audit branch September 19, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants