Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): revert zero timelock protocol #208

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

kangsorang
Copy link
Contributor

@kangsorang kangsorang commented Oct 4, 2023

Description

Revert #167, remove protocol for using custom time-lock zero delay for urgent situations.
The default Timelock delay has also been changed to 7 days.

@kangsorang kangsorang requested a review from a team as a code owner October 4, 2023 10:07
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update our spec docs as well?

@kangsorang kangsorang force-pushed the feat/revert-zero-timelock branch 2 times, most recently from 32a75d9 to b86bc6a Compare October 5, 2023 01:44
packages/contracts/contracts/governance/TimeLock.sol Outdated Show resolved Hide resolved
specs/contract-upgrades.md Outdated Show resolved Hide resolved
specs/security-council.md Outdated Show resolved Hide resolved
Remove protocol for using custom time-lock zero delay for urgent situations.
The default Timelock delay has also been changed to 7 days.
@kangsorang kangsorang force-pushed the feat/revert-zero-timelock branch from b86bc6a to c666e0a Compare October 6, 2023 02:34
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@seolaoh seolaoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xHansLee 0xHansLee merged commit 3d8b1a9 into dev Oct 6, 2023
@0xHansLee 0xHansLee deleted the feat/revert-zero-timelock branch October 6, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants