chore: add deploy config for l2 protocol governance #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seolaoh
reviewed
Oct 18, 2023
0xHansLee
approved these changes
Oct 18, 2023
kangsorang
force-pushed
the
chore/add-deploy-config-l2-governance
branch
3 times, most recently
from
51c2c06 to
42d7c70
Compare
seolaoh
reviewed
Oct 18, 2023
seolaoh
reviewed
Oct 18, 2023
kangsorang
force-pushed
the
chore/add-deploy-config-l2-governance
branch
2 times, most recently
from
2ffa28c to
3c7e2c3
Compare
Deploy config added - l2GovernorVotingPeriodBlocks. Seperate transfetOwnership action to hardhat task. Rollback mainnet config timeLockMinDelaySeconds. This value will be managed separately.
kangsorang
force-pushed
the
chore/add-deploy-config-l2-governance
branch
from
3c7e2c3 to
275cede
Compare
seolaoh
force-pushed
the
chore/add-deploy-config-l2-governance
branch
from
08afeaf to
275cede
Compare
|
I force pushed another commit in mistake. Just reverted it, so please ignore it. |
Pangssu
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deploy config added - l2GovernorVotingPeriodBlocks.
Seperate transfetOwnership action to hardhat task.
Rollback the change in #207, which is related to mainnet config timeLockMinDelaySeconds. This value will be managed separately.