Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev -> Main #220

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Dev -> Main #220

merged 7 commits into from
Oct 24, 2023

Conversation

seolaoh
Copy link
Contributor

@seolaoh seolaoh commented Oct 20, 2023

Description

This is merge PR for v1.0.1.
After #212 which is previously merged for v1.0.1, we added some additional commits which include contract deployments.

@seolaoh seolaoh requested a review from a team as a code owner October 20, 2023 04:22
Since we do not need `securityCouncilTokenOwner` anymore, remove it and use
`proxyAdminOwner` for `SystemConfig` owner in e2e tests.
Unify the term indicating ownership of the system to `proxyAdminOwner`. Actually after transferring ownership in real contracts, this variable might be only used for e2e tests.
…ciltokenowner-config

chore: remove `securityCouncilTokenOwner` from deploy config
Copy link
Contributor

@kangsorang kangsorang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seolaoh seolaoh merged commit 503ae2e into main Oct 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants