Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refac!: renaming about proposer #221

Merged
merged 2 commits into from
Oct 25, 2023
Merged

refac!: renaming about proposer #221

merged 2 commits into from
Oct 25, 2023

Conversation

kangsorang
Copy link
Contributor

Description

Renaming about proposer.

  • Renaming Proposer to Sequencer.
  • Renaming ProposerRewardVault to L1FeeVault.
  • Update specs & assets.

@kangsorang kangsorang requested a review from therocks October 23, 2023 00:56
@kangsorang kangsorang requested review from a team as code owners October 23, 2023 00:56
@Pangssu
Copy link
Contributor

Pangssu commented Oct 23, 2023

To follow the git message convention, use refac:

@Pangssu
Copy link
Contributor

Pangssu commented Oct 23, 2023

Please edit below files
specs/glossary.md (L298-769)
specs/differences-from-optimism-bedrock.md (L54)
components/batcher/channel_builder.go (L54)
components/batcher/config.go (L74)
components/batcher/flags/flags.go (L41)
components/node/node/config.go (L25)
components/node/rollup/derive/attributes_queue.go (L90)

@kangsorang
Copy link
Contributor Author

kangsorang commented Oct 23, 2023 •
edited
Loading

I applied the code in all but two cases below.

specs/glossary.md (L298-769)

  • In the case of "proposal", which I often see, I thought it was being used in a different sense. Even in the OP, there are parts that use the word proposal.

specs/differences-from-optimism-bedrock.md (L54)

  • Here, proposer makes more sense in context.

@kangsorang kangsorang force-pushed the refactor/renaming-proposer-to-sequencer branch from 440e097 to d92f8e1 Compare October 23, 2023 04:36
@kangsorang kangsorang changed the title refactor: renaming about proposer refac: renaming about proposer Oct 23, 2023
@kangsorang kangsorang changed the title refac: renaming about proposer refactor: renaming about proposer Oct 23, 2023
@kangsorang kangsorang self-assigned this Oct 23, 2023
@seolaoh seolaoh changed the title refactor: renaming about proposer refac: renaming about proposer Oct 23, 2023
seolaoh
seolaoh reviewed Oct 23, 2023
View reviewed changes
bindings/Makefile Show resolved Hide resolved
components/node/rollup/driver/sequencer.go Outdated Show resolved Hide resolved
components/node/rollup/driver/state.go Outdated Show resolved Hide resolved
components/node/rollup/driver/state.go Outdated Show resolved Hide resolved
components/node/rollup/driver/state.go Outdated Show resolved Hide resolved
e2e/actions/reorg_test.go Outdated Show resolved Hide resolved
e2e/system_test.go Outdated Show resolved Hide resolved
e2e/system_test.go Outdated Show resolved Hide resolved
e2e/system_test.go Outdated Show resolved Hide resolved
components/node/flags/flags.go Outdated Show resolved Hide resolved
@seolaoh
Copy link
Contributor

seolaoh commented Oct 23, 2023 •
edited
Loading

Could you remove other unused branch related to this?

seolaoh
seolaoh reviewed Oct 23, 2023
View reviewed changes
packages/contracts/contracts/test/FeeVault.t.sol Outdated Show resolved Hide resolved
specs/deposits.md Outdated Show resolved Hide resolved
seolaoh
seolaoh reviewed Oct 23, 2023
View reviewed changes
specs/glossary.md Outdated Show resolved Hide resolved
specs/overview.md Outdated Show resolved Hide resolved
specs/overview.md Outdated Show resolved Hide resolved
@kangsorang kangsorang force-pushed the refactor/renaming-proposer-to-sequencer branch 2 times, most recently from 0b34e5c to 63f41d6 Compare October 23, 2023 13:12
0xHansLee
0xHansLee reviewed Oct 24, 2023
View reviewed changes
components/node/node/runtime_config.go Outdated Show resolved Hide resolved
components/node/rollup/derive/engine_queue_test.go Outdated Show resolved Hide resolved
components/node/rollup/derive/engine_queue_test.go Outdated Show resolved Hide resolved
e2e/actions/reorg_test.go Show resolved Hide resolved
packages/contracts/deployments/kroma/L1FeeVault.json Outdated Show resolved Hide resolved
specs/glossary.md Outdated Show resolved Hide resolved
specs/glossary.md Outdated Show resolved Hide resolved
specs/glossary.md Outdated Show resolved Hide resolved
specs/glossary.md Outdated Show resolved Hide resolved
specs/glossary.md Outdated Show resolved Hide resolved
seolaoh
seolaoh reviewed Oct 24, 2023
View reviewed changes
bindings/Makefile Outdated Show resolved Hide resolved
components/node/rollup/driver/state.go Outdated Show resolved Hide resolved
@kangsorang kangsorang force-pushed the refactor/renaming-proposer-to-sequencer branch from 63f41d6 to 5d9dcff Compare October 24, 2023 06:39
@kangsorang kangsorang force-pushed the refactor/renaming-proposer-to-sequencer branch 3 times, most recently from 39f2e7a to ceb147f Compare October 24, 2023 07:35
0xHansLee
0xHansLee reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update .gas-snapshot again.

specs/glossary.md Outdated Show resolved Hide resolved
packages/contracts/deployments/kroma/L1FeeVault.json Outdated Show resolved Hide resolved
@kangsorang kangsorang force-pushed the refactor/renaming-proposer-to-sequencer branch from ceb147f to 395d8ae Compare October 24, 2023 08:04
@seolaoh seolaoh changed the title refac: renaming about proposer refac!: renaming about proposer Oct 24, 2023
seolaoh
seolaoh approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@seolaoh seolaoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xHansLee
0xHansLee approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kangsorang kangsorang force-pushed the refactor/renaming-proposer-to-sequencer branch from 395d8ae to e5834cd Compare October 25, 2023 00:00
@therocks
Copy link
Member

LGTM

@therocks therocks closed this Oct 25, 2023
@therocks therocks reopened this Oct 25, 2023
@Pangssu Pangssu merged commit 55cf9ba into dev Oct 25, 2023
1 of 2 checks passed
@Pangssu Pangssu deleted the refactor/renaming-proposer-to-sequencer branch October 25, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seolaoh seolaoh seolaoh approved these changes

@0xHansLee 0xHansLee 0xHansLee approved these changes

@therocks therocks therocks approved these changes

@Pangssu Pangssu Pangssu approved these changes

Assignees

@kangsorang kangsorang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kangsorang @Pangssu @seolaoh @therocks @0xHansLee