feat!: upstream to optimism v1.2.0 #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rn/chai-4.3.10 build(deps): bump chai from 4.3.9 to 4.3.10
feat(op-challenger): Output Trace Provider
…rn/hardhat-2.17.4 build(deps-dev): bump hardhat from 2.17.2 to 2.17.4
…evelop CI: Store test results after running indexer tests
…rn/glob-10.3.10 build(deps-dev): bump glob from 10.3.3 to 10.3.10
…rn/swc/core-1.3.90 build(deps-dev): bump @swc/core from 1.3.76 to 1.3.90
Bumps ethereum/client-go from v1.13.1 to v1.13.2. --- updated-dependencies: - dependency-name: ethereum/client-go dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.27.10 to 1.28.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.27.10...v1.28.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…rn/viem-1.13.0 build(deps): bump viem from 1.3.1 to 1.13.0
Bumps [viem](https://github.com/wagmi-dev/viem) from 1.13.0 to 1.14.0. - [Release notes](https://github.com/wagmi-dev/viem/releases) - [Commits](https://github.com/wagmi-dev/viem/compare/viem@1.13.0...viem@1.14.0) --- updated-dependencies: - dependency-name: viem dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@vitest/coverage-istanbul](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-istanbul) from 0.34.1 to 0.34.6. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v0.34.6/packages/coverage-istanbul) --- updated-dependencies: - dependency-name: "@vitest/coverage-istanbul" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
feat(ctb): Move storage getters and setters to own lib
* Multiple mergify queues. * Update urgent label * Use queue conditions as opposed to conditions field
kangsorang
force-pushed
the
feat/op-upstream
branch
2 times, most recently
from
2fc6f1d to
731a681
Compare
kangsorang
force-pushed
the
feat/op-upstream
branch
from
731a681 to
1d59e9b
Compare
kangsorang
force-pushed
the
feat/op-upstream
branch
3 times, most recently
from
f06c961 to
b351574
Compare
kangsorang
force-pushed
the
feat/op-upstream
branch
from
b351574 to
561a3c7
Compare
That's clear, I agree. |
kangsorang
force-pushed
the
feat/op-upstream
branch
4 times, most recently
from
f87b6f6 to
304cfeb
Compare
Fixed to keep op-form names for components we didn't create.
kangsorang
force-pushed
the
feat/op-upstream
branch
from
304cfeb to
3c69db0
Compare
Pangssu
reviewed
Nov 29, 2023
kangsorang
force-pushed
the
feat/op-upstream
branch
from
3c69db0 to
bc2577b
Compare
kangsorang
force-pushed
the
feat/op-upstream
branch
from
bc2577b to
3a87909
Compare
Yes I mean some contract code changes which could be applied to Kroma also. Are there any decisions not to apply contract code changes further? |
That wasn't the decision. I think we can work on that in the future if we see the need. |
Pangssu
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Working upstream on updates to Optimism v1.2.0.
A merge commit has been created with Optimism based on Kroma that reflects content up to Optimism v1.0.3.
Any future upstream work can now be merged using the Optimism repo.
I have reflected the necessary Optimism components centered on Batcher and Node.
I also worked to match the existing Kroma structure with Optimism as much as possible for future upstream convenience.
To make it easier to track changes between Optimism and Kroma in code, I didn't apply any additional linters.
NOTE:
The version of the KROMA GETH you are importing references a GETH whose work is not currently complete. It will be updated later.
Golang version has been updated, it needs to be configured.
BREAKINGS
Need to rename fields in rollup config
max_proposer_drift -> max_sequencer_drift
proposer_window_size -> seq_window_size
ENV renaming required due to node flag changes
NODE_PROPOSER_ENABLED -> NODE_SEQUENCER_ENABLED
NODE_PROPOSER_L1_CONFS -> NODE_SEQUENCER_L1_CONFS
NODE_SYNCER_L1_CONFS -> NODE_VERIFIER_L1_CONFS
Adding a required configuration environment variable to add validation logic
VALIDATOR_RPC_ADDR
VALIDATOR_RPC_PORT
VALIDATOR_RPC_ENABLE_ADMIN