Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add blob related things to rpc header #247

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

0xHansLee
Copy link
Contributor

@0xHansLee 0xHansLee commented Jan 31, 2024

Merge into release/v1.1.1-base branch, which is a base branch for releasing v1.1.1.
With dencun upgrade, blob related fields are added to block header.
Accordingly, those should be added. Without this, the validation of block header when starting node is failed.

msg="failed to fetch L1 head for runtime config initialization" err=failed to fetch head header:  failed to verify block hash: computed 0xaaa but RPC said 0xbbb"

After merging this PR, v1.1.1 will be released. Also, this should be applied to v1.2.0-rc.*, where the upstreamed version is v1.3.0, since this is added in Optimism v1.4.0.

Summary by CodeRabbit

  • Refactor
    • Updated the data structure to include new fields for enhanced transaction processing and tracking.

With dencun upgrade, blob related fields are added to block header.
Accordingly, those should be added. Without this, the validation of block header
when starting node is failed.
@0xHansLee 0xHansLee added the bug Something isn't working label Jan 31, 2024
@0xHansLee 0xHansLee requested a review from a team January 31, 2024 13:15
@0xHansLee 0xHansLee self-assigned this Jan 31, 2024
Copy link
Contributor

coderabbitai bot commented Jan 31, 2024

Walkthrough

The op-service's types.go file saw significant updates to the rpcHeader struct, enhancing blockchain operations with new data fields and optimizations. These changes include the addition of BlobGasUsed, ExcessBlobGas, and ParentBeaconRoot to better manage gas usage and parent beacon references, along with an adjustment to WithdrawalsRoot for conditional inclusion. The createGethHeader method was also refined to incorporate these new fields, ensuring seamless integration within the system.

Changes

File Path Change Summary
.../sources/types.go Added BlobGasUsed, ExcessBlobGas, ParentBeaconRoot; updated WithdrawalsRoot and createGethHeader method.

🐇✨
In the code's woven nest, a change does sprout,
Fields new, a method's cheer, without a doubt.
Through bytes and bits, our journey's root,
A rabbit's hop in pursuit of tech's sweet fruit.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@Pangssu
Copy link
Contributor

Pangssu commented Jan 31, 2024

@coderabbitai review

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 0dfa632 and 87b18ec.
Files selected for processing (1)
  • op-service/sources/types.go (2 hunks)
Additional comments: 2
op-service/sources/types.go (2)
  • 139-148: The addition of the omitempty tags to the WithdrawalsRoot, BlobGasUsed, ExcessBlobGas, and ParentBeaconRoot fields in the rpcHeader struct is correctly implemented. These tags ensure that these fields are omitted from the JSON output if they are not set, which is a good practice for optional fields.
  • 201-204: The integration of the new fields (BlobGasUsed, ExcessBlobGas, ParentBeaconRoot) into the createGethHeader method is correctly done. This ensures that the types.Header struct will include these fields, aligning with the requirements for the dencun upgrade. However, ensure that the type conversions ((*uint64)(hdr.BlobGasUsed), (*uint64)(hdr.ExcessBlobGas), hdr.ParentBeaconRoot) are safe and will not lead to runtime panics due to nil pointer dereferences when these fields are nil.

@0xHansLee 0xHansLee merged commit 526fc48 into release/v1.1.1-base Jan 31, 2024
1 check passed
@0xHansLee 0xHansLee deleted the fix/add-blob-header branch January 31, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants