Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set mainnet delta upgrade time #259

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

0xHansLee
Copy link
Contributor

@0xHansLee 0xHansLee commented Feb 22, 2024

This PR enables Delta upgrade on mainnet.
The activation time is 1709107200, which is Wed Feb 28 2024 08:00:00 UTC.

Summary by CodeRabbit

  • Refactor
    • Updated the configuration for the Mainnet to enhance operational timing.

@0xHansLee 0xHansLee requested a review from a team February 22, 2024 01:57
@0xHansLee 0xHansLee self-assigned this Feb 22, 2024
@0xHansLee 0xHansLee requested a review from a team as a code owner February 22, 2024 01:57
Copy link
Contributor

coderabbitai bot commented Feb 22, 2024

Walkthrough

The update involves modifying the Mainnet configuration within the rollup.Config structure by setting the DeltaTime value, which was previously nil, to a specific unsigned 64-bit integer (1709107200). This alteration affects both the main configuration file and its corresponding test file, ensuring consistency across the codebase.

Changes

Files Change Summary
op-node/chaincfg/chains.go, .../chains_test.go Updated DeltaTime in Mainnet config from nil to 1709107200.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9160b2d and e222f5b.
Files ignored due to path filters (1)
  • ops-devnet/docker-compose.yml is excluded by: !**/*.yml
Files selected for processing (2)
  • op-node/chaincfg/chains.go (1 hunks)
  • op-node/chaincfg/chains_test.go (1 hunks)
Additional comments: 2
op-node/chaincfg/chains.go (1)
  • 43-43: The update to the DeltaTime value for the Mainnet configuration is correctly set to u64Ptr(1709107200), aligning with the PR's objective to schedule the Delta upgrade on the Ethereum mainnet for Wednesday, February 28, 2024, at 08:00:00 UTC. This change is critical for the upgrade's timing and appears to be correctly implemented.
op-node/chaincfg/chains_test.go (1)
  • 70-70: The update to the DeltaTime value in the mainnetCfg variable for testing purposes is correctly set to u64Ptr(1709107200), mirroring the change made in the main configuration file (chains.go). This ensures consistency between the main configuration and its tests, which is crucial for validating the Delta upgrade scheduling on the Ethereum mainnet.

Copy link
Contributor

@seolaoh seolaoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kangsorang kangsorang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xHansLee 0xHansLee merged commit 3b31e12 into dev Feb 22, 2024
2 checks passed
@0xHansLee 0xHansLee deleted the feat/set-mainnet-delta branch February 22, 2024 04:16
0xHansLee added a commit that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants