-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set mainnet delta upgrade time #259
Conversation
WalkthroughThe update involves modifying the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
ops-devnet/docker-compose.yml
is excluded by:!**/*.yml
Files selected for processing (2)
- op-node/chaincfg/chains.go (1 hunks)
- op-node/chaincfg/chains_test.go (1 hunks)
Additional comments: 2
op-node/chaincfg/chains.go (1)
- 43-43: The update to the
DeltaTime
value for the Mainnet configuration is correctly set tou64Ptr(1709107200)
, aligning with the PR's objective to schedule the Delta upgrade on the Ethereum mainnet for Wednesday, February 28, 2024, at 08:00:00 UTC. This change is critical for the upgrade's timing and appears to be correctly implemented.op-node/chaincfg/chains_test.go (1)
- 70-70: The update to the
DeltaTime
value in themainnetCfg
variable for testing purposes is correctly set tou64Ptr(1709107200)
, mirroring the change made in the main configuration file (chains.go
). This ensures consistency between the main configuration and its tests, which is crucial for validating the Delta upgrade scheduling on the Ethereum mainnet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR enables Delta upgrade on mainnet.
The activation time is 1709107200, which is Wed Feb 28 2024 08:00:00 UTC.
Summary by CodeRabbit