feat: upstream to optimism v1.7.2 #282
Conversation
Bumps [@wagmi/cli](https://github.com/wevm/wagmi/tree/HEAD/packages/cli) from 2.1.0 to 2.1.1. - [Release notes](https://github.com/wevm/wagmi/releases) - [Changelog](https://github.com/wevm/wagmi/blob/main/packages/cli/CHANGELOG.md) - [Commits](https://github.com/wevm/wagmi/commits/@wagmi/cli@2.1.1/packages/cli) --- updated-dependencies: - dependency-name: "@wagmi/cli" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* op-bindings * op-challenger n ops
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.11.16 to 20.11.17. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@swc/core](https://github.com/swc-project/swc) from 1.3.106 to 1.4.1. - [Release notes](https://github.com/swc-project/swc/releases) - [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md) - [Commits](swc-project/swc@v1.3.106...v1.4.1) --- updated-dependencies: - dependency-name: "@swc/core" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [nx](https://github.com/nrwl/nx/tree/HEAD/packages/nx) from 18.0.2 to 18.0.4. - [Release notes](https://github.com/nrwl/nx/releases) - [Commits](https://github.com/nrwl/nx/commits/18.0.4/packages/nx) --- updated-dependencies: - dependency-name: nx dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The fault proof tests aren't being load balanced particularly well so an executor sometimes takes more than 40m to run.
* op-challenger: Add a wrapper to allow validating output roots are safe at a given L1 head * op-challenger: Don't pass L1Head around so much. * op-challenger: Rename and add tests. * Update bindings. * Update op-ufm go.sum * Rollback op-ufm changes. * op-challenger: Alphabet VM does not require checking for consistency with L1 data * op-challenger: Add error handling test.
* ci: Tag fp-squad when op-e2e-cannon-tests fails * ci: Also tag proofs squad on fpp-verify failures.
* FP: add KZG point-evaluation preimage-oracle type, to process L2 oracle call with * op-program: Integrate kzg precompile oracle * fix PreimageOracle.sol * store kzg precompile input preimage * update bindings and go.mod * fix go.mod * resolve TODOs * s/Hex2Bytes/FromHex * fix typo * ctb: set kzg preimage length to 1 * op-challenger: Load kzg point evaluations to PreimageOracle (#9497) * op-challenger: load KZG point evaluation into oracle Also: increase max game depth for devnet. This is a temporary solution to avoid flakes in e2e tests that use the kzg precompile. The current execution trace max step of 2**31 steps isn't sufficient. --------- Co-authored-by: inphi <mlaw2501@gmail.com> Co-authored-by: refcell <abigger87@gmail.com>
1 second time outs in CI is just asking for flakiness.
… (#9512) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.19.1 to 6.21.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.21.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix * another * not -> neither
* add additional check before emitting log warning * Update op-node/rollup/derive/engine_controller.go Co-authored-by: protolambda <proto@protolambda.com> --------- Co-authored-by: protolambda <proto@protolambda.com>
kangsorang
force-pushed
the
feat/upstream-optimism
branch
from
0fc6657 to
6f57d95
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Status
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.modis excluded by!**/*.mod,!**/*.modgo.sumis excluded by!**/*.sum,!**/*.sum
Files selected for processing (16)
- .changeset/config.json (1 hunks)
- .gitignore (2 hunks)
- CONTRIBUTING.md (3 hunks)
- LICENSE (2 hunks)
- UPSTREAM.md (1 hunks)
- kroma-bindings/bindings/l1block.go (4 hunks)
- kroma-bindings/bindings/l1block_more.go (1 hunks)
- kroma-bindings/predeploys/addresses_test.go (1 hunks)
- kroma-bindings/predeploys/beacon_deposit.go (1 hunks)
- kroma-chain-ops/genesis/config.go (19 hunks)
- kroma-chain-ops/genesis/genesis.go (7 hunks)
- kroma-chain-ops/genesis/layer_one.go (6 hunks)
- kroma-chain-ops/genesis/setters.go (3 hunks)
- kroma-chain-ops/immutables/immutables.go (9 hunks)
- kroma-devnet/README.md (1 hunks)
- kroma-devnet/devnet/init.py (8 hunks)
Files skipped from review as they are similar to previous changes (11)
- .changeset/config.json
- LICENSE
- kroma-bindings/bindings/l1block.go
- kroma-bindings/bindings/l1block_more.go
- kroma-bindings/predeploys/addresses_test.go
- kroma-bindings/predeploys/beacon_deposit.go
- kroma-chain-ops/genesis/config.go
- kroma-chain-ops/genesis/genesis.go
- kroma-chain-ops/genesis/layer_one.go
- kroma-chain-ops/genesis/setters.go
- kroma-devnet/devnet/init.py
Additional comments not posted (5)
UPSTREAM.md (1)
1-5: The version information for Optimism is correctly updated and formatted.kroma-devnet/README.md (1)
5-5: The instructions for invoking the script have been updated accurately and are clear. It's good to see that feedback from previous reviews has been incorporated..gitignore (1)
1-37: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [2-47]
The updates to
.gitignoreare appropriate and seem to reflect the project's current needs.Ensure that the removals, such as
.env*and__pycache__, align with the project's current structure and build process.Verification successful
The shell script output supports the updates made to the
.gitignorefile, showing that.envfiles, except for examples like.env.example, are intended to be excluded from version control, which aligns with common practices. The absence of__pycache__directories suggests that either Python code is not a significant part of this project anymore, or that these directories are being managed differently, justifying their exclusion. The review comment's suggestion to verify the removals was appropriate, and the verification confirms the appropriateness of the changes.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that the removed paths are no longer generated or are handled differently. # Example check for .env files fd '.env' --type f # Example check for __pycache__ directories fd '__pycache__' --type dLength of output: 76
kroma-chain-ops/immutables/immutables.go (2)
197-201: Ensure proper error handling when creating a new L2 backend. The current implementation is correct, but always double-check error paths for new external calls.
264-272: Verify the handling of type assertions and ensure they are correctly implemented, especially when dealing with external inputs or configurations.
kangsorang
force-pushed
the
feat/upstream-optimism
branch
from
6f57d95 to
3605bc4
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Review Status
Configuration used: CodeRabbit UI
Files ignored due to path filters (5)
go.modis excluded by!**/*.mod,!**/*.modgo.sumis excluded by!**/*.sum,!**/*.sumkroma-chain-ops/genesis/testdata/allocs-l1.jsonis excluded by!**/*.jsonkroma-chain-ops/genesis/testdata/deploy.jsonis excluded by!**/*.jsonkroma-chain-ops/genesis/testdata/l1-deployments.jsonis excluded by!**/*.json
Files selected for processing (17)
- .changeset/config.json (1 hunks)
- .gitignore (2 hunks)
- CONTRIBUTING.md (3 hunks)
- LICENSE (2 hunks)
- UPSTREAM.md (1 hunks)
- kroma-bindings/bindings/l1block.go (4 hunks)
- kroma-bindings/bindings/l1block_more.go (1 hunks)
- kroma-bindings/predeploys/addresses_test.go (1 hunks)
- kroma-bindings/predeploys/beacon_deposit.go (1 hunks)
- kroma-chain-ops/genesis/config.go (19 hunks)
- kroma-chain-ops/genesis/genesis.go (7 hunks)
- kroma-chain-ops/genesis/layer_one.go (6 hunks)
- kroma-chain-ops/genesis/setters.go (3 hunks)
- kroma-chain-ops/immutables/immutables.go (9 hunks)
- kroma-devnet/README.md (1 hunks)
- kroma-devnet/devnet/init.py (8 hunks)
- kroma-validator/config.go (1 hunks)
Files skipped from review as they are similar to previous changes (11)
- .changeset/config.json
- LICENSE
- kroma-bindings/bindings/l1block.go
- kroma-bindings/bindings/l1block_more.go
- kroma-bindings/predeploys/addresses_test.go
- kroma-bindings/predeploys/beacon_deposit.go
- kroma-chain-ops/genesis/config.go
- kroma-chain-ops/genesis/genesis.go
- kroma-chain-ops/genesis/layer_one.go
- kroma-chain-ops/genesis/setters.go
- kroma-devnet/devnet/init.py
Additional comments not posted (6)
UPSTREAM.md (1)
1-5: LGTM! The version information is correctly updated to reflect the upgrade to Optimism v1.7.2.kroma-devnet/README.md (1)
5-5: LGTM! The command update is correctly documented to reflect the changes in how to invoke the script for running a local Bedrock devnet..gitignore (1)
1-37: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [2-47]
Verify the removals from
.gitignoreto ensure they align with the project's current setup and dependency management strategy.kroma-validator/config.go (1)
18-18: LGTM! The correction of the import path for theoppprofpackage is accurate and necessary.kroma-chain-ops/immutables/immutables.go (2)
84-94: LGTM! The addition of new structs is comprehensive and necessary for the project's functionality.
264-272: Verify the removal of the "L2ToL1MessagePasser" case as mentioned in a previous comment.
| * [Git](https://git-scm.com/downloads) | ||
| * [NodeJS](https://nodejs.org/en/download/) | ||
| * [Node Version Manager](https://github.com/nvm-sh/nvm) | ||
| * [pnpm](https://pnpm.io/installation) | ||
| * [Docker](https://docs.docker.com/get-docker/) | ||
| * [Docker Compose](https://docs.docker.com/compose/install/) | ||
| * [Go](https://go.dev/dl/) | ||
| * [Foundry](https://getfoundry.sh) | ||
| * [jq](https://jqlang.github.io/jq/) | ||
| * [go-ethereum](https://github.com/ethereum/go-ethereum) |
There was a problem hiding this comment.
Update the spelling of "NodeJS" to "Node.js" to align with the official terminology.
- * [NodeJS](https://nodejs.org/en/download/)
+ * [Node.js](https://nodejs.org/en/download/)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * [Git](https://git-scm.com/downloads) | |
| * [NodeJS](https://nodejs.org/en/download/) | |
| * [Node Version Manager](https://github.com/nvm-sh/nvm) | |
| * [pnpm](https://pnpm.io/installation) | |
| * [Docker](https://docs.docker.com/get-docker/) | |
| * [Docker Compose](https://docs.docker.com/compose/install/) | |
| * [Go](https://go.dev/dl/) | |
| * [Foundry](https://getfoundry.sh) | |
| * [jq](https://jqlang.github.io/jq/) | |
| * [go-ethereum](https://github.com/ethereum/go-ethereum) | |
| * [Git](https://git-scm.com/downloads) | |
| * [Node.js](https://nodejs.org/en/download/) | |
| * [Node Version Manager](https://github.com/nvm-sh/nvm) | |
| * [pnpm](https://pnpm.io/installation) | |
| * [Docker](https://docs.docker.com/get-docker/) | |
| * [Docker Compose](https://docs.docker.com/compose/install/) | |
| * [Go](https://go.dev/dl/) | |
| * [Foundry](https://getfoundry.sh) | |
| * [jq](https://jqlang.github.io/jq/) | |
| * [go-ethereum](https://github.com/ethereum/go-ethereum) |
|
|
||
| l2: | ||
| pid: host # allow debugging | ||
| image: kromanetwork/geth:v0.4.5-rc.2 | ||
| image: kromanetwork/geth:upstream |
There was a problem hiding this comment.
We need to update this when geth released.
There was a problem hiding this comment.
Yes, I will update it at the end of the PR.
# Conflicts: # go.mod # go.sum # ops-devnet/docker-compose.yml
kangsorang
force-pushed
the
feat/upstream-optimism
branch
from
3605bc4 to
640a775
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
Review Status
Configuration used: CodeRabbit UI
Files ignored due to path filters (6)
go.modis excluded by!**/*.mod,!**/*.modgo.sumis excluded by!**/*.sum,!**/*.sumkroma-chain-ops/genesis/testdata/allocs-l1.jsonis excluded by!**/*.jsonkroma-chain-ops/genesis/testdata/deploy.jsonis excluded by!**/*.jsonkroma-chain-ops/genesis/testdata/l1-deployments.jsonis excluded by!**/*.jsonkroma-chain-ops/genesis/testdata/test-deploy-config-full.jsonis excluded by!**/*.json
Files selected for processing (17)
- .changeset/config.json (1 hunks)
- .gitignore (2 hunks)
- CONTRIBUTING.md (3 hunks)
- LICENSE (2 hunks)
- UPSTREAM.md (1 hunks)
- kroma-bindings/bindings/l1block.go (4 hunks)
- kroma-bindings/bindings/l1block_more.go (1 hunks)
- kroma-bindings/predeploys/addresses_test.go (1 hunks)
- kroma-bindings/predeploys/beacon_deposit.go (1 hunks)
- kroma-chain-ops/genesis/config.go (19 hunks)
- kroma-chain-ops/genesis/genesis.go (7 hunks)
- kroma-chain-ops/genesis/layer_one.go (6 hunks)
- kroma-chain-ops/genesis/setters.go (3 hunks)
- kroma-chain-ops/immutables/immutables.go (9 hunks)
- kroma-devnet/README.md (1 hunks)
- kroma-devnet/devnet/init.py (8 hunks)
- kroma-validator/config.go (3 hunks)
Files skipped from review as they are similar to previous changes (12)
- .changeset/config.json
- LICENSE
- kroma-bindings/bindings/l1block.go
- kroma-bindings/bindings/l1block_more.go
- kroma-bindings/predeploys/addresses_test.go
- kroma-bindings/predeploys/beacon_deposit.go
- kroma-chain-ops/genesis/config.go
- kroma-chain-ops/genesis/genesis.go
- kroma-chain-ops/genesis/layer_one.go
- kroma-chain-ops/genesis/setters.go
- kroma-devnet/devnet/init.py
- kroma-validator/config.go
Additional comments not posted (3)
UPSTREAM.md (1)
1-5: LGTM! The version information for Optimism is clearly stated and correctly formatted.kroma-devnet/README.md (1)
2-5: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-5]
LGTM! The instructions for running a local Bedrock devnet are clear and correctly formatted.
kroma-chain-ops/immutables/immutables.go (1)
22-58: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [14-316]
LGTM! The additions of new structs and updates to the
Deployfunction are necessary for the project's functionality and align with the upgrade to Optimism v1.7.2.
|
|
||
| # PyCharm | ||
| # JetBrains specific template is maintained in a separate JetBrains.gitignore that can | ||
| # be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore | ||
| # and can be added to the global gitignore or merged into this file. For a more nuclear | ||
| # option (not recommended) you can uncomment the following to ignore the entire idea folder. | ||
| #.idea/ | ||
|
|
||
| ### Vim ### | ||
| # Swap | ||
| [._]*.s[a-v][a-z] | ||
| !*.svg # comment out if you don't need vector files | ||
| [._]*.sw[a-p] | ||
| [._]s[a-rt-v][a-z] | ||
| [._]ss[a-gi-z] | ||
| [._]sw[a-p] | ||
|
|
||
| # Session | ||
| Session.vim | ||
| Sessionx.vim | ||
|
|
||
| # Temporary | ||
| .netrwhist | ||
| # Auto-generated tag files | ||
| tags | ||
| # Persistent undo | ||
| [._]*.un~ | ||
|
|
||
| ### VisualStudioCode ### | ||
| .vscode/* | ||
| !.vscode/settings.json | ||
| !.vscode/tasks.json | ||
| !.vscode/launch.json | ||
| !.vscode/extensions.json | ||
| !.vscode/*.code-snippets | ||
|
|
||
| # Local History for Visual Studio Code | ||
| .history/ | ||
|
|
||
| # Built Visual Studio Code Extensions | ||
| *.vsix | ||
|
|
||
| ### VisualStudioCode Patch ### | ||
| # Ignore all local history of files | ||
| .history | ||
| .ionide | ||
|
|
||
| ### yarn ### | ||
| # https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored | ||
|
|
||
| yarn-error.log | ||
| .yarn/* | ||
| !.yarn/releases | ||
| !.yarn/patches | ||
| !.yarn/plugins | ||
| !.yarn/sdks | ||
| !.yarn/versions | ||
|
|
||
| # if you are NOT using Zero-installs, then: | ||
| # comment the following lines | ||
| !.yarn/cache | ||
| .pnp.* | ||
|
|
||
| # and uncomment the following lines | ||
| # .pnp.* | ||
| dist | ||
| artifacts | ||
| cache | ||
| bin | ||
|
|
||
| # End of https://www.toptal.com/developers/gitignore/api/go,node,python,yarn,vim,visualstudiocode,linux,macos | ||
| # vim | ||
| *.sw* | ||
|
|
||
| ### JetBrains ### | ||
| .idea | ||
| # jetbrains | ||
| .idea/ | ||
|
|
||
| ### Hardhat ### | ||
| cache | ||
| artifacts | ||
| !/op-bindings/hardhat/testdata/artifacts/ | ||
| .secrets | ||
| .env | ||
| .env* | ||
| !.env.example | ||
| !.envrc.example | ||
| *.log | ||
|
|
||
| ### Devnet | ||
| .devnet | ||
| packages/contracts/deployments/devnetL1 | ||
|
|
||
| ### Misc ### | ||
| # Ignore all binary folders | ||
| bin/ | ||
|
|
||
| # Ignore local fuzzing results | ||
| **/testdata/fuzz/ |
There was a problem hiding this comment.
Tip
Codebase Verification
The executed script found references to the entries that were removed from the .gitignore file across various files in the project. This suggests that the project still makes use of or references these directories and file types. It's recommended to review these findings and assess whether any of the removed entries should be added back to .gitignore to prevent potential issues such as unwanted tracking of files by Git or exposure of sensitive information.
Analysis chain
📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [2-47]
Verify the changes in the .gitignore file, especially the removals, to ensure they align with the project's current structure and dependencies.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for references to removed .gitignore entries in the project
rg --files-with-matches '.yarn/|.pnp.|.secrets|.env|*.log|__pycache__|crytic-export'
Length of output: 247
Script:
#!/bin/bash
# Corrected search for references to removed .gitignore entries in the project
# Escaping special characters in the regex pattern
rg --files-with-matches '\.yarn/|\.pnp\.|\.\secrets|\.env|\*\.log|__pycache__|crytic-export'
Length of output: 1664
| - [Go](https://go.dev/dl/) | ||
| - [Foundry](https://getfoundry.sh) | ||
| * [Git](https://git-scm.com/downloads) | ||
| * [NodeJS](https://nodejs.org/en/download/) |
There was a problem hiding this comment.
Update the spelling of "NodeJS" to "Node.js" to align with the official terminology.
- * [NodeJS](https://nodejs.org/en/download/)
+ * [Node.js](https://nodejs.org/en/download/)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * [NodeJS](https://nodejs.org/en/download/) | |
| * [Node.js](https://nodejs.org/en/download/) |
kangsorang
force-pushed
the
feat/upstream-optimism
branch
from
2d4edee to
1efec1c
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (2)
- kroma-bindings/bindings/l1block.go (4 hunks)
- kroma-bindings/bindings/l1block_more.go (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- kroma-bindings/bindings/l1block.go
- kroma-bindings/bindings/l1block_more.go
kangsorang
force-pushed
the
feat/upstream-optimism
branch
from
1670641 to
0e9844c
Compare
Description
This is a PR to upstream to Optimism v1.7.2. (v1.4.0 -> v1.7.2)
For the new op-conductors and op-plasmas in the OPs included in this scope of work, I approached disabling them via flags rather than excluding code.
To avoid issues with Optimism remote merges recognizing conflicts, I perform a traditional merge rather than a squash merge.
The default setting for devnet is pre-ecotone because E2E tests are built on the assumption of a pre-ecotone environment.
To enable ecotone from genesis, I recommend that you modify the following part of the devoteL1-templte.json file and build it.
For more information, see the links below.
Summary by CodeRabbit
New Features
kroma-validatormodule for improved logging and transaction submission.Documentation
op-bindingsmodule.Refactor
.gitignorefor better file management.kroma-chain-opsmodule with comprehensive updates for configuration and deployment.kroma-devnetscripts and environment variables for improved local testing.op-batchermodule for improved performance and configurability.Chores
gethinstallation.Bug Fixes
Style
Tests
Revert