-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(validator): implement validator client and fix actions test #288
feat(validator): implement validator client and fix actions test #288
Conversation
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent updates focus on enhancing the functionality and interaction of validator contracts within the Kroma ecosystem. Key changes include the introduction of new initialization functions, modifications to contract deployment and management, and updates to testing and configuration settings. Notably, the governance token's structure was altered by removing inheritance traits and updating permissions, which aligns with broader changes in contract management and challenge creation capabilities. Changes
This table summarizes the extensive updates made across different components of the Kroma platform, focusing on improving contract interactions, testing, and deployment strategies. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
340e463
to
07ef6fd
Compare
9795ebe
to
a0f5571
Compare
26b4f56
to
453aeeb
Compare
453aeeb
to
b97ee89
Compare
Added a commit that updates |
9f98e21
to
5544e3f
Compare
bc2a2d8
to
1392622
Compare
bc59abe
to
d459839
Compare
1392622
to
10be0bf
Compare
b0db29f
to
944d68b
Compare
10be0bf
to
e3c1b38
Compare
944d68b
to
f2c08a0
Compare
f2c08a0
to
c0adc23
Compare
c0adc23
to
5931c37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5931c37
to
07dd2b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7942dad
to
b9bec16
Compare
@0xHansLee I restored two of changes regarding your feedbacks (link 1 & 2), since I think they are duplicates for the below return statements at L#332 & L#654. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b9bec16
to
6c80279
Compare
8169f41
into
feat/implement-validator-system-v2
Description
Implemented handling logics at
kroma-validator
client, and fixed the relevant actions test atop-e2e
. Adding the commands for validators and system test for the new validator client will be handled with the following PRs.For proper testing,
GovernanceToken
is changed.Ownable
atGovernanceToken
is temporarily removed to allow minting the tokens inside the test code and check the behavior of validator client, after the successful transition to new validator system. This must be fixed after PR #269 is merged.Also, this PR includes an addition of flags that is needed to run devnet.
This PR must be merged after PR #269 and #277 are merged into
dev
.