feat(validator): remove the limit of validator subcommand amount flag

[seolaoh]

Description

Since the validator subcommand amount flag had a type of uint64, the flag was limited to a maximum value of about 18 ETH. By changing the type of the amount flag to string, it is possible to use unlimited values for the flag.

Summary by CodeRabbit

• New Features
  • Enhanced the handling of transaction amounts in the deposit and withdraw commands to accept string inputs, allowing for more flexible and precise transactions.

[coderabbitai]

Walkthrough

The recent update transitions the handling of transaction amounts from a uint64 data type to a string. This change applies to both the Deposit and Withdraw functions, as well as the sendTransaction function, enhancing the handling of large transaction values by using big.Int for parsing. Additionally, CLI command flags for specifying transaction amounts have been updated to accept strings, reflecting this shift in data type handling.

Changes

Files	Change Summary
.../balance/cmd.go	Updated Deposit and Withdraw functions to accept amount as a string. Withdraw parses amount to big.Int. sendTransaction accepts txValue as a string.
cmd/main.go	Modified deposit and withdraw command flags from Uint64Flag to StringFlag for the amount parameter.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 05d5e24 and 332889c.

Files selected for processing (2)

• kroma-validator/cmd/balance/cmd.go (5 hunks)
• kroma-validator/cmd/main.go (2 hunks)

Additional comments not posted (5)

kroma-validator/cmd/main.go (2)

37-37: The change from Uint64Flag to StringFlag for the amount parameter in the deposit command aligns with the PR objectives. Ensure that the Deposit function correctly parses the string value to a numeric type for further processing.

---

49-49: The change from Uint64Flag to StringFlag for the amount parameter in the withdraw command is appropriate. Ensure that the Withdraw function correctly handles the string value by parsing it to a numeric type.

kroma-validator/cmd/balance/cmd.go (3)

20-20: Fetching the amount parameter as a string in the Deposit function aligns with the PR objectives. Ensure that the sendTransaction function correctly handles the string value.

---

40-45: The handling of the amount parameter as a string in the Withdraw function, including parsing it to a big.Int and appropriate error handling, is well-implemented and aligns with the PR objectives.

---

91-106: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [82-97]

Accepting the txValue parameter as a string in the sendTransaction function and parsing it to a big.Int with appropriate error handling is a necessary change that aligns with the PR objectives.