Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contracts): fix some bugs related to AssetManager #327

Merged
merged 8 commits into from
Jun 5, 2024
Merged

fix(contracts): fix some bugs related to AssetManager #327

merged 8 commits into from
Jun 5, 2024

Conversation

seolaoh
Copy link
Contributor

@seolaoh seolaoh commented May 29, 2024

Description

Fix some bugs related to AssetManager. I recommend to review commit by commit, since I've written the relevant context in the commit messages.

seolaoh added 2 commits May 29, 2024 17:03
@seolaoh
fix(contracts): correctly subtract from validator delegated KRO when …
5da55f2 
…undelegate

When undelegate, only validator delegated KRO should be subtracted from
`validatorKro`. The accumulated base reward should not be subtracted from
`validatorKro`.
@seolaoh
fix(contracts): correct the input of _convertToKroAssets
2c97773 
Previously, the input of `_convertToKroAssets` was wrong, so correct it from KGH
shares to token ID. Also organize some public functions of `AssetManager` since
previous version of `previewKghUndelegate` is not appropriate for public use.
@seolaoh seolaoh self-assigned this May 29, 2024
@seolaoh seolaoh requested a review from a team as a code owner May 29, 2024 08:11
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 29, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@seolaoh seolaoh marked this pull request as draft May 30, 2024 05:41
@seolaoh seolaoh force-pushed the fix/fix-bugs-asset-manager branch from e8e4260 to 1682000 Compare May 30, 2024 06:30
@seolaoh seolaoh marked this pull request as ready for review May 30, 2024 06:31
@seolaoh seolaoh force-pushed the fix/fix-bugs-asset-manager branch from 1682000 to 561e944 Compare May 30, 2024 07:54
seolaoh added 6 commits May 31, 2024 14:17
@seolaoh
fix(contracts): replace msg.sender in view function with argument
ed3e7bb 
Since `msg.sender` in view function is zero address, we should not use it.
@seolaoh
feat(contracts): add getter of validatorRewardKro
b23ca85
@seolaoh
chore: rename assetMan to assetMgr
2e461b5
@seolaoh
feat(contracts): don't need to update validator tree before jail
20d1b37 
Since the validator will be removed from the validator tree when jailed, we
don't need to update validator tree before sending the validator to the jail.
@seolaoh
fix(contracts): update validator KRO when slashing
c7abfae 
`validatorKro` is included in `totalKro`, so it does not need to be included in
calculation of slashing amount. But we need to update this value as well when
modifying each asset of vault when applying slash.
@seolaoh
chore(contracts): update bindings and snapshots
bcf70e8
@seolaoh seolaoh force-pushed the fix/fix-bugs-asset-manager branch from 561e944 to bcf70e8 Compare May 31, 2024 05:17
@seolaoh
Copy link
Contributor Author

seolaoh commented May 31, 2024

@0xHansLee I just added some new commits related to bugs that found in challenge test. I did not separate it into another PR because it's not that big change and it's also related to AssetManager. Can you review the commits added after you approved? Thank you in advance.

0xHansLee
0xHansLee approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed and looks good to me. Thank you for your efforts.

sm-stack
sm-stack approved these changes Jun 1, 2024
View reviewed changes
Copy link
Contributor

@sm-stack sm-stack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seolaoh seolaoh merged commit 9c507ba into feat/implement-validator-system-v2 Jun 5, 2024
2 checks passed
@seolaoh seolaoh deleted the fix/fix-bugs-asset-manager branch June 5, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sm-stack sm-stack sm-stack approved these changes

@0xHansLee 0xHansLee 0xHansLee approved these changes

@Pangssu Pangssu Pangssu approved these changes

Assignees

@seolaoh seolaoh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seolaoh @Pangssu @0xHansLee @sm-stack