Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove KGH share and modify KGH delegation func #349

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

0xHansLee
Copy link
Contributor

@0xHansLee 0xHansLee commented Jul 18, 2024

Handling of boosted reward and 1 step undelegation will be covered in the following PR.

Will be merged after merging #347 and #348.

@0xHansLee 0xHansLee requested review from seolaoh and sm-stack July 18, 2024 08:10
@0xHansLee 0xHansLee self-assigned this Jul 18, 2024
@0xHansLee 0xHansLee requested a review from a team as a code owner July 18, 2024 08:10
Copy link
Contributor

coderabbitai bot commented Jul 18, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (2)
  • dev
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
@0xHansLee
Copy link
Contributor Author

@seolaoh I made changes regarding your review in b46b6a5.
In the commit, all codes related to undelegation are rollbacked. I will handle it in the following PR.

packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@seolaoh seolaoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…v2' into feat/remove-ksh-share

# Conflicts:
#	packages/contracts/contracts/L1/AssetManager.sol
@0xHansLee 0xHansLee merged commit bf82155 into feat/implement-validator-system-v2 Jul 19, 2024
1 of 2 checks passed
@0xHansLee 0xHansLee deleted the feat/remove-ksh-share branch July 19, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants