Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): add transferFrom when increasing reward of vault #354

Merged

Conversation

sm-stack
Copy link
Contributor

@sm-stack sm-stack commented Jul 21, 2024

Description

Added transferFrom function and logic of adding validator and boosted reward at increaseBalanceWithReward function.

Must be merged after #351

@sm-stack sm-stack requested review from 0xHansLee and seolaoh July 21, 2024 07:13
@sm-stack sm-stack self-assigned this Jul 21, 2024
@sm-stack sm-stack requested a review from a team as a code owner July 21, 2024 07:13
Copy link
Contributor

coderabbitai bot commented Jul 21, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (2)
  • dev
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sm-stack sm-stack removed the request for review from a team July 21, 2024 07:13
@sm-stack sm-stack force-pushed the feat/transfer-from-reward-vault branch from 6d34e1f to 8e092b5 Compare July 21, 2024 07:20
@sm-stack sm-stack changed the base branch from feat/implement-validator-system-v2 to feat/unbond-validator-kro July 21, 2024 07:21
@sm-stack sm-stack force-pushed the feat/transfer-from-reward-vault branch from ec5c35a to 8e092b5 Compare July 21, 2024 08:24
@sm-stack
Copy link
Contributor Author

Just checked this functionality works well with Safe Sepolia account. cc. @seolaoh @0xHansLee

Copy link
Contributor

@seolaoh seolaoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feat/unbond-validator-kro to feat/implement-validator-system-v2 July 22, 2024 09:08
@sm-stack sm-stack force-pushed the feat/transfer-from-reward-vault branch from 1877bfc to 474792e Compare July 22, 2024 09:20
@sm-stack sm-stack force-pushed the feat/transfer-from-reward-vault branch from 474792e to cbea862 Compare July 22, 2024 09:22
@sm-stack sm-stack force-pushed the feat/transfer-from-reward-vault branch from cbea862 to 533bd67 Compare July 22, 2024 09:25
@sm-stack sm-stack merged commit 627c070 into feat/implement-validator-system-v2 Jul 22, 2024
1 of 2 checks passed
@sm-stack sm-stack deleted the feat/transfer-from-reward-vault branch July 22, 2024 09:29
@sm-stack sm-stack restored the feat/transfer-from-reward-vault branch July 22, 2024 09:29
@sm-stack sm-stack deleted the feat/transfer-from-reward-vault branch July 22, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants