fix(contracts): not upgrade already deployed contract #371
Conversation
WalkthroughThe recent changes to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DeployUtils
participant Contract
User->>DeployUtils: deploy(name, opts)
DeployUtils->>DeployUtils: deployImpl(hre, name, opts)
DeployUtils->>Contract: Deploy contract
Contract-->>DeployUtils: (contract, newlyDeployed)
DeployUtils-->>User: return contract (if newlyDeployed)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/contracts/src/deploy-utils.ts (5 hunks)
Additional comments not posted (3)
packages/contracts/src/deploy-utils.ts (3)
46-49: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
deploymatch the new signature.Verification successful
All function calls to
deploymatch the new signature.The changes are consistent across the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `deploy` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type ts -A 5 $'deploy('Length of output: 94
Script:
#!/bin/bash # Description: Verify all function calls to `deploy` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type ts -A 5 'deploy\('Length of output: 19304
167-173: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
deployImplmatch the new signature.Also applies to: 204-204, 221-221
Verification successful
All function calls to
deployImplmatch the new signature.The function
deployImplis correctly used with the new signature in the codebase.
packages/contracts/src/deploy-utils.ts: Both usages ofdeployImplreturn a tuple[created, newlyDeployed].Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `deployImpl` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type ts -A 5 $'deployImpl('Length of output: 106
Script:
#!/bin/bash # Description: Verify all function calls to `deployImpl` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type ts -A 5 $'deployImpl\\('Length of output: 817
113-116: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
deployAndUpgradeByDeployermatch the new signature.
Description
There was a bug in this change, so I fixed it. If the contract is not deployed newly, skip upgrading the proxy contract.