Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change predeploy contract addresses #398

Merged
merged 14 commits into from
Dec 16, 2024

Conversation

kangsorang
Copy link
Contributor

@kangsorang kangsorang commented Dec 9, 2024

Description

Change predeploy contract addresses.

Includes 8 transactions behaviors for upgrades in MPT blocks.

Behaves similarly to ecotone upgrades.

One difference is that upgrade transactions are executed in MPT block - 1 instead of MPT block.

@kangsorang kangsorang requested review from a team as code owners December 9, 2024 02:03
Copy link
Contributor

coderabbitai bot commented Dec 9, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • dev
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kangsorang kangsorang marked this pull request as draft December 9, 2024 02:13
@kangsorang kangsorang force-pushed the feat/change-predeploys-addr branch 2 times, most recently from 9b3a1da to 79ccbeb Compare December 9, 2024 23:59
@kangsorang kangsorang force-pushed the feat/change-predeploys-addr branch from 79ccbeb to 8457619 Compare December 10, 2024 06:07
@kangsorang kangsorang marked this pull request as ready for review December 10, 2024 06:30
op-node/rollup/derive/attributes.go Outdated Show resolved Hide resolved
op-node/rollup/derive/attributes.go Outdated Show resolved Hide resolved
op-node/rollup/derive/kromampt_upgrade_transactions.go Outdated Show resolved Hide resolved
op-node/rollup/derive/kromampt_upgrade_transactions.go Outdated Show resolved Hide resolved
op-node/rollup/derive/span_channel_out.go Outdated Show resolved Hide resolved
op-node/rollup/types.go Outdated Show resolved Hide resolved
op-node/rollup/types.go Outdated Show resolved Hide resolved
op-node/rollup/types.go Outdated Show resolved Hide resolved
op-node/rollup/types.go Outdated Show resolved Hide resolved
op-node/rollup/types.go Outdated Show resolved Hide resolved
op-node/rollup/derive/kromampt_upgrade_transactions.go Outdated Show resolved Hide resolved
op-node/rollup/derive/kromampt_upgrade_transactions.go Outdated Show resolved Hide resolved
op-node/rollup/derive/kromampt_upgrade_transactions.go Outdated Show resolved Hide resolved
kroma-bindings/predeploys/addresses_test.go Outdated Show resolved Hide resolved
kroma-bindings/predeploys/addresses_test.go Outdated Show resolved Hide resolved
op-node/rollup/derive/attributes_queue_test.go Outdated Show resolved Hide resolved
@kangsorang kangsorang force-pushed the feat/change-predeploys-addr branch from 32e0a05 to 20d9450 Compare December 11, 2024 07:35
op-node/rollup/types.go Outdated Show resolved Hide resolved
@kangsorang kangsorang force-pushed the feat/change-predeploys-addr branch from 2a61806 to 905ac77 Compare December 11, 2024 08:02
seolaoh
seolaoh previously approved these changes Dec 12, 2024
@seolaoh seolaoh dismissed their stale review December 13, 2024 08:29

re-review the new changes

@kangsorang kangsorang force-pushed the feat/change-predeploys-addr branch from 762f6b6 to 0de6ec0 Compare December 13, 2024 12:07
@kangsorang kangsorang force-pushed the feat/change-predeploys-addr branch from 08f1403 to ecd0cb1 Compare December 16, 2024 06:07
@seolaoh seolaoh merged commit 561d0b7 into feat/zkvm-fault-proof Dec 16, 2024
3 checks passed
@seolaoh seolaoh deleted the feat/change-predeploys-addr branch December 16, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants