test(e2e): add fee distribution test in Kroma MPT #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
kangsorang
reviewed
Dec 17, 2024
op-e2e/system_test.go
Outdated
| @@ -1549,6 +1526,18 @@ func testFees(t *testing.T, cfg SystemConfig) { | |||
| validatorRewardVaultStartBalance, err := l2Seq.BalanceAt(context.Background(), predeploys.ValidatorRewardVaultAddr, big.NewInt(rpc.EarliestBlockNumber.Int64())) | |||
| require.Nil(t, err) | |||
|
|
|||
| // Fee recipients after Kroma MPT | |||
There was a problem hiding this comment.
I think it would be nice to have a before and after conditional block, like if !sys.RollupConfig.IsKromaMPT(header.Time), or do you have another intention?
sm-stack
reviewed
Dec 17, 2024
kangsorang
reviewed
Dec 17, 2024
op-e2e/system_test.go
Outdated
| // Wait until Kroma MPT migration completed when it's set | ||
| if cfg.DeployConfig.L2GenesisKromaMPTTimeOffset != nil { | ||
| mptTimeOffset := *cfg.DeployConfig.L2GenesisKromaMPTTimeOffset | ||
| mptMigrationNextBlock := uint64(mptTimeOffset)/cfg.DeployConfig.L2BlockTime + 1 |
There was a problem hiding this comment.
Since the transition is applied from mptMigrationBlock, wouldn't it be more accurate to test by MPT block instead of next?
seolaoh
force-pushed
the
test/distribute-fee-mpt
branch
from
347670f to
e610b40
Compare
Base automatically changed from
feat/add-op-l1block
to
feat/zkvm-fault-proof
December 18, 2024 05:55
|
Could you rebase please? |
seolaoh
force-pushed
the
test/distribute-fee-mpt
branch
2 times, most recently
from
85f4990 to
839536f
Compare
seolaoh
changed the base branch from
feat/zkvm-fault-proof
to
feat/delay-engine-call
Pangssu
approved these changes
Dec 18, 2024
Pangssu
force-pushed
the
feat/delay-engine-call
branch
2 times, most recently
from
8b125c0 to
863d987
Compare
Base automatically changed from
feat/delay-engine-call
to
feat/zkvm-fault-proof
December 19, 2024 05:05
seolaoh
force-pushed
the
test/distribute-fee-mpt
branch
from
839536f to
553f007
Compare
sm-stack
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the fee distribution test in Kroma MPT.
The setup for historical RPC node and other nodes are repeated in all tests for Kroma MPT, so I added a utility function and global variable to set up MPT environment in system config setup.